GREASE is now RFC 8701. I forgot to update the references. Change-Id: I1a746eec13afd9fd1e59ca1824b2dd0f83ff7f74 Reviewed-on: https://boringssl-review.googlesource.com/c/boringssl/+/47666 Reviewed-by: Adam Langley <agl@google.com>
diff --git a/include/openssl/ssl.h b/include/openssl/ssl.h index 2aac4e9..998dbbb 100644 --- a/include/openssl/ssl.h +++ b/include/openssl/ssl.h
@@ -4260,7 +4260,7 @@ int enable); // SSL_CTX_set_grease_enabled configures whether sockets on |ctx| should enable -// GREASE. See draft-davidben-tls-grease-01. +// GREASE. See RFC 8701. OPENSSL_EXPORT void SSL_CTX_set_grease_enabled(SSL_CTX *ctx, int enabled); // SSL_max_seal_overhead returns the maximum overhead, in bytes, of sealing a
diff --git a/ssl/handshake_client.cc b/ssl/handshake_client.cc index b12113b..7e2fbb5 100644 --- a/ssl/handshake_client.cc +++ b/ssl/handshake_client.cc
@@ -223,7 +223,7 @@ return false; } - // Add a fake cipher suite. See draft-davidben-tls-grease-01. + // Add a fake cipher suite. See RFC 8701. if (ssl->ctx->grease_enabled && !CBB_add_u16(&child, ssl_get_grease_value(hs, ssl_grease_cipher))) { return false;
diff --git a/ssl/internal.h b/ssl/internal.h index bfd2ab6..b572931 100644 --- a/ssl/internal.h +++ b/ssl/internal.h
@@ -3506,7 +3506,7 @@ // advertise support. bool channel_id_enabled : 1; - // grease_enabled is whether draft-davidben-tls-grease-01 is enabled. + // grease_enabled is whether GREASE (RFC 8701) is enabled. bool grease_enabled : 1; // allow_unknown_alpn_protos is whether the client allows unsolicited ALPN
diff --git a/ssl/t1_lib.cc b/ssl/t1_lib.cc index 42bfe6d..cdb9016 100644 --- a/ssl/t1_lib.cc +++ b/ssl/t1_lib.cc
@@ -2326,7 +2326,7 @@ return CBB_flush(out); } } else { - // Add a fake group. See draft-davidben-tls-grease-01. + // Add a fake group. See RFC 8701. if (ssl->ctx->grease_enabled && (!CBB_add_u16(&kse_bytes, ssl_get_grease_value(hs, ssl_grease_group)) || @@ -2503,7 +2503,7 @@ return false; } - // Add a fake version. See draft-davidben-tls-grease-01. + // Add a fake version. See RFC 8701. if (ssl->ctx->grease_enabled && !CBB_add_u16(&versions, ssl_get_grease_value(hs, ssl_grease_version))) { return false; @@ -2556,7 +2556,7 @@ return false; } - // Add a fake group. See draft-davidben-tls-grease-01. + // Add a fake group. See RFC 8701. if (ssl->ctx->grease_enabled && !CBB_add_u16(&groups_bytes, ssl_get_grease_value(hs, ssl_grease_group))) { @@ -3337,7 +3337,7 @@ uint16_t grease_ext1 = 0; if (ssl->ctx->grease_enabled) { - // Add a fake empty extension. See draft-davidben-tls-grease-01. + // Add a fake empty extension. See RFC 8701. grease_ext1 = ssl_get_grease_value(hs, ssl_grease_extension1); if (!CBB_add_u16(&extensions, grease_ext1) || !CBB_add_u16(&extensions, 0 /* zero length */)) { @@ -3365,7 +3365,7 @@ } if (ssl->ctx->grease_enabled) { - // Add a fake non-empty extension. See draft-davidben-tls-grease-01. + // Add a fake non-empty extension. See RFC 8701. uint16_t grease_ext2 = ssl_get_grease_value(hs, ssl_grease_extension2); // The two fake extensions must not have the same value. GREASE values are
diff --git a/ssl/test/runner/common.go b/ssl/test/runner/common.go index 1e93fbb..fa2ba6c 100644 --- a/ssl/test/runner/common.go +++ b/ssl/test/runner/common.go
@@ -1650,7 +1650,7 @@ InvalidChannelIDSignature bool // ExpectGREASE, if true, causes messages without GREASE values to be - // rejected. See draft-davidben-tls-grease-01. + // rejected. See RFC 8701. ExpectGREASE bool // OmitPSKsOnSecondClientHello, if true, causes the client to omit the
diff --git a/ssl/tls13_server.cc b/ssl/tls13_server.cc index f3f4853..cb14e7e 100644 --- a/ssl/tls13_server.cc +++ b/ssl/tls13_server.cc
@@ -188,7 +188,7 @@ } } - // Add a fake extension. See draft-davidben-tls-grease-01. + // Add a fake extension. See RFC 8701. if (!CBB_add_u16(&extensions, ssl_get_grease_value(hs, ssl_grease_ticket_extension)) || !CBB_add_u16(&extensions, 0 /* empty */)) {