| commit | 35e07a80d8c8b35c390467f485a9be4202ed9ec1 | [log] [tgz] |
|---|---|---|
| author | David Benjamin <davidben@google.com> | Thu May 01 11:05:14 2025 -0400 |
| committer | Boringssl LUCI CQ <boringssl-scoped@luci-project-accounts.iam.gserviceaccount.com> | Fri May 02 10:01:22 2025 -0700 |
| tree | dcc34a4d5d94879df0c5f8f87b4760f1a119fdfc | |
| parent | bc70ca75b1b2530b718ccc3ec2b31fe535bd7481 [diff] |
Remove some dead code from SSL_CTX_use_certificate_chain_file SSL_CTX_use_certificate_chain_file has some extra logic where, if SSL_CTX_use_certificate succeeds but leaves an error in the error queue, it fails anyway. The comment claims it's because, on cert/key mismatch, it succeeds and leaves an error. When the function was added in upstream's b3ca645f479b1f0bcfa1d1a65c955e8b7ff33de6, this appears to have been true. However, years later upstream's 6049399bafac74bd809ffac2108e8d5d284cd720 added an ERR_clear_error and made SSL_CTX_use_certificate behave more consistently. Now the behavior is that installing a certificate silently clears any pre-existing mismatched keys, so this case no longer exists. The recently-added tests also demonstrate this behavior. Change-Id: I4c7de44046f10bc653f8f1fd86aff0d6956b2b1a Reviewed-on: https://boringssl-review.googlesource.com/c/boringssl/+/79009 Auto-Submit: David Benjamin <davidben@google.com> Reviewed-by: Adam Langley <agl@google.com> Commit-Queue: David Benjamin <davidben@google.com>
BoringSSL is a fork of OpenSSL that is designed to meet Google's needs.
Although BoringSSL is an open source project, it is not intended for general use, as OpenSSL is. We don't recommend that third parties depend upon it. Doing so is likely to be frustrating because there are no guarantees of API or ABI stability.
Programs ship their own copies of BoringSSL when they use it and we update everything as needed when deciding to make API changes. This allows us to mostly avoid compromises in the name of compatibility. It works for us, but it may not work for you.
BoringSSL arose because Google used OpenSSL for many years in various ways and, over time, built up a large number of patches that were maintained while tracking upstream OpenSSL. As Google's product portfolio became more complex, more copies of OpenSSL sprung up and the effort involved in maintaining all these patches in multiple places was growing steadily.
Currently BoringSSL is the SSL library in Chrome/Chromium, Android (but it's not part of the NDK) and a number of other apps/programs.
Project links:
To file a security issue, use the Chromium process and mention in the report this is for BoringSSL. You can ignore the parts of the process that are specific to Chromium/Chrome.
There are other files in this directory which might be helpful: