| commit | c6722cd6e0da9c7f00566cbe4bf7eb3dca107cf6 | [log] [tgz] |
|---|---|---|
| author | David Benjamin <davidben@google.com> | Mon Oct 24 20:13:20 2016 -0400 |
| committer | CQ bot account: commit-bot@chromium.org <commit-bot@chromium.org> | Tue Oct 25 20:15:45 2016 +0000 |
| tree | 2de8347e84826af4987f79f6b8831778cbbee54e | |
| parent | 35c8afd3143289c99aa3820e01950c564d7aced8 [diff] |
Check SSL_MODE_ACCEPT_MOVING_WRITE_BUFFER before touching wpend_buf. SSL_write has messy semantics around retries. As a sanity-check, it does pointer and length checks and requires the original and retry SSL_write pass the same buffer pointer. In some cases, buffer addresses may change but still include the original data as a prefix on the retry. Callers then set SSL_MODE_ACCEPT_MOVING_WRITE_BUFFER to skip the pointer check. But, in that case, the pointer may have been freed so doing a comparison is undefined behavior. Short-circuiting the pointer equality check avoids this problem. Change-Id: I76cb8f7d45533504cd95287bc53897ca636af51d Reviewed-on: https://boringssl-review.googlesource.com/11760 CQ-Verified: CQ bot account: commit-bot@chromium.org <commit-bot@chromium.org> Reviewed-by: Steven Valdez <svaldez@google.com> Reviewed-by: David Benjamin <davidben@google.com> Commit-Queue: David Benjamin <davidben@google.com>
BoringSSL is a fork of OpenSSL that is designed to meet Google's needs.
Although BoringSSL is an open source project, it is not intended for general use, as OpenSSL is. We don't recommend that third parties depend upon it. Doing so is likely to be frustrating because there are no guarantees of API or ABI stability.
Programs ship their own copies of BoringSSL when they use it and we update everything as needed when deciding to make API changes. This allows us to mostly avoid compromises in the name of compatibility. It works for us, but it may not work for you.
BoringSSL arose because Google used OpenSSL for many years in various ways and, over time, built up a large number of patches that were maintained while tracking upstream OpenSSL. As Google's product portfolio became more complex, more copies of OpenSSL sprung up and the effort involved in maintaining all these patches in multiple places was growing steadily.
Currently BoringSSL is the SSL library in Chrome/Chromium, Android (but it's not part of the NDK) and a number of other apps/programs.
There are other files in this directory which might be helpful: