)]}'
{
  "commit": "34e474f794fcc6338cc8ee5aab7123c11e8f998b",
  "tree": "f81111f4f1ff33bba796b8bae06546150c04b30d",
  "parents": [
    "10fef972e47d1621b76af959733802167b8d4075"
  ],
  "author": {
    "name": "David Benjamin",
    "email": "davidben@google.com",
    "time": "Wed Aug 31 12:57:55 2022 -0400"
  },
  "committer": {
    "name": "Boringssl LUCI CQ",
    "email": "boringssl-scoped@luci-project-accounts.iam.gserviceaccount.com",
    "time": "Wed Aug 31 19:18:54 2022 +0000"
  },
  "message": "Check set_encrypt_key return value in AESTest.ABI.\n\nOn aarch64 and x86_64 ABIs, the unused bits of 32-bit parameters have\nunspecified value. That means if, say, the aarch64\naes_hw_set_encrypt_key accessed the \u0027bits\u0027 parameter as X1 rather than\nW1, it could get a different value from what C passed in. To test this,\nour ABI testing framework fills the upper half of the register with\ngarbage.  However, set_encrypt_key just cleanly returns error on\nunrecognized bit length. So, to check that this all worked correctly, we\nneed to assert that the return value was correct.\n\nLooking at the assembly, they all handle it correctly, but now we\u0027ll\nalso test it.\n\n(Note these functions break the usual convention and use zero as the\nsuccess value.)\n\nChange-Id: Icaf65ea54564ebfe3696b42287488fe3f72ef138\nReviewed-on: https://boringssl-review.googlesource.com/c/boringssl/+/54205\nCommit-Queue: David Benjamin \u003cdavidben@google.com\u003e\nCommit-Queue: Bob Beck \u003cbbe@google.com\u003e\nAuto-Submit: David Benjamin \u003cdavidben@google.com\u003e\nReviewed-by: Bob Beck \u003cbbe@google.com\u003e\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "a38bf9c22914f4282fd33342feb56ecb95a09c84",
      "old_mode": 33188,
      "old_path": "crypto/fipsmodule/aes/aes_test.cc",
      "new_id": "dd3b3748af94c2fa258e3852ae50fe1c00b3fde1",
      "new_mode": 33188,
      "new_path": "crypto/fipsmodule/aes/aes_test.cc"
    }
  ]
}
