commit 2e24b9bf7310d42f4d715e12c504ec6357033a07
author Brian Smith <brian@briansmith.org> Mon Nov 02 15:05:11 2015 -1000
committer Adam Langley <agl@google.com> Fri Nov 06 20:06:54 2015 +0000
tree ad96f26ef7a9b9e18688e25414576097b8039381
parent e82e6f6696127e660584d5809d72046b87a81cb1

Allow SHA-512 unaligned data access in |OPENSSL_NO_ASM| mode.

The previous logic only defined
|SHA512_BLOCK_CAN_MANAGE_UNALIGNED_DATA| when the assembly language
optimizations were enabled, but
|SHA512_BLOCK_CAN_MANAGE_UNALIGNED_DATA| is also useful when the C
implementations are used.

If support for ARM processors that don't support unaligned access is
important, then it might be better to condition the enabling of
|SHA512_BLOCK_CAN_MANAGE_UNALIGNED_DATA| on ARM based on more specific
flags.

Change-Id: Ie8c37c73aba308c3ccf79371ce5831512e419989
Reviewed-on: https://boringssl-review.googlesource.com/6402
Reviewed-by: Adam Langley <agl@google.com>

crypto/sha/sha512.c

diff --git a/crypto/sha/sha512.c b/crypto/sha/sha512.c
index 5e77a1e..beb0f8c 100644
--- a/crypto/sha/sha512.c
+++ b/crypto/sha/sha512.c
@@ -78,10 +78,14 @@
 #if !defined(OPENSSL_NO_ASM) &&                         \
     (defined(OPENSSL_X86) || defined(OPENSSL_X86_64) || \
      defined(OPENSSL_ARM) || defined(OPENSSL_AARCH64))
-#define SHA512_BLOCK_CAN_MANAGE_UNALIGNED_DATA
 #define SHA512_ASM
 #endif
 
+#if defined(OPENSSL_X86) || defined(OPENSSL_X86_64) || \
+    defined(__ARM_FEATURE_UNALIGNED)
+#define SHA512_BLOCK_CAN_MANAGE_UNALIGNED_DATA
+#endif
+
 int SHA384_Init(SHA512_CTX *sha) {
   sha->h[0] = OPENSSL_U64(0xcbbb9d5dc1059ed8);
   sha->h[1] = OPENSSL_U64(0x629a292a367cd507);