)]}'
{
  "commit": "2ce5dbc237c94c3a1d62e6f5fb5c0128fe0c4ddc",
  "tree": "640b95d347c260b4c6af144f360865c61c2d1e18",
  "parents": [
    "416c97a300659ebd17a202464f769ee245c003b8"
  ],
  "author": {
    "name": "Rudolf Polzer",
    "email": "rpolzer@google.com",
    "time": "Fri Dec 19 02:56:36 2025 -0800"
  },
  "committer": {
    "name": "Boringssl LUCI CQ",
    "email": "boringssl-scoped@luci-project-accounts.iam.gserviceaccount.com",
    "time": "Fri Dec 19 09:54:28 2025 -0800"
  },
  "message": "Fix namespacing of err_save_state_st.\n\nIn I1893343fee1b43b3e31e9d66a244475ffc4a35f1, this struct was moved to\nthe bssl namespace.\n\nTurns out it does not work to define a struct this way; it causes deltas\nin the symbol names when symbol prefixing is turned on:\n\n$ for f in libcrypto.a CMakeFiles/crypto_test.dir/**/*.o; do nm -a \"$f\" | grep ERR_restore_state; done\n0000000000001a08 T __ZN4bssl14brlogenshfegle17ERR_restore_stateEPKNS_17err_save_state_stE\n                 U __ZN4bssl14brlogenshfegle17ERR_restore_stateEPKNS0_17err_save_state_stE\n$ for f in libcrypto.a CMakeFiles/crypto_test.dir/**/*.o; do nm --demangle -a \"$f\" | grep ERR_restore_state; done\n0000000000001a08 T bssl::brlogenshfegle::ERR_restore_state(bssl::err_save_state_st const*)\n                 U bssl::brlogenshfegle::ERR_restore_state(bssl::brlogenshfegle::err_save_state_st const*)\n\nSo it looks like the bssl:: hack can currently only be used for variable\nand function definitions, and most definitely not for types.\n\nNote that this issue only happens with Clang, not with GCC:\nhttps://godbolt.org/z/nsq5K95dc \u003c-\u003e https://godbolt.org/z/fhfMn5Td6\n\nBug: 42220000\nChange-Id: Ic1396212ce1baed6b53a4ed92c089a1d145bd480\nReviewed-on: https://boringssl-review.googlesource.com/c/boringssl/+/86067\nAuto-Submit: Rudolf Polzer \u003crpolzer@google.com\u003e\nReviewed-by: David Benjamin \u003cdavidben@google.com\u003e\nCommit-Queue: David Benjamin \u003cdavidben@google.com\u003e\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "491070ce7f16939759e8bd2b7d0866ffe90be6b7",
      "old_mode": 33188,
      "old_path": "crypto/err/err.cc",
      "new_id": "3c51ae4a1a1d788ac3521e7a8ddce76c4081be23",
      "new_mode": 33188,
      "new_path": "crypto/err/err.cc"
    }
  ]
}
