)]}' { "commit": "2cb7b337d00e6b7106b2fec84f4b2c90e2baa484", "tree": "42c72731369965b641992552456f2ecc92e25e01", "parents": [ "cc575425302e35700848358be85166ff2c5e832e" ], "author": { "name": "David Benjamin", "email": "davidben@google.com", "time": "Wed Dec 28 19:31:26 2022 -0500" }, "committer": { "name": "Boringssl LUCI CQ", "email": "boringssl-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Thu Mar 16 22:13:42 2023 +0000" }, "message": "Rewrite ASN1_OBJECT and ASN1_BOOLEAN d2i/i2d functions.\n\nThese functions already don\u0027t go through tasn_*.c. Rewrite them to use\nCBS and CBB. This removes some dependencies on ASN1_get_object and\nASN1_put_object.\n\nUpdate-Note: d2i_ASN1_OBJECT and d2i_ASN1_BOOLEAN will no longer accept\nnon-minimal length prefixes (forbidden in DER). d2i_ASN1_BOOLEAN will\nalso no longer accept non-canonical representations of TRUE (also\nforbidden in DER). This does not affect certificate parsing, as that\nstill goes through the old template system, though we will make a\nsimilar change to those functions later.\n\nBug: 354, 548\nChange-Id: I0b7aa96f47aca5c31ec4f702e27108b4106311f2\nReviewed-on: https://boringssl-review.googlesource.com/c/boringssl/+/58145\nCommit-Queue: David Benjamin \u003cdavidben@google.com\u003e\nReviewed-by: Bob Beck \u003cbbe@google.com\u003e\nCommit-Queue: Bob Beck \u003cbbe@google.com\u003e\nAuto-Submit: David Benjamin \u003cdavidben@google.com\u003e\n", "tree_diff": [ { "type": "modify", "old_id": "67d6813a40e61b6f023d7f24c0af3b1929c890cb", "old_mode": 33188, "old_path": "crypto/asn1/a_bool.c", "new_id": "e227b7f7969bce70b9892b5406a05153104ff02d", "new_mode": 33188, "new_path": "crypto/asn1/a_bool.c" }, { "type": "modify", "old_id": "56219e1f81c200014b04f3a8497489067c18da77", "old_mode": 33188, "old_path": "crypto/asn1/a_object.c", "new_id": "77bd175ea78d8121ecc6482841335b91df0f6b40", "new_mode": 33188, "new_path": "crypto/asn1/a_object.c" }, { "type": "modify", "old_id": "36ad6760139e3a84f9f3b02c28f0deb4167c393f", "old_mode": 33188, "old_path": "crypto/asn1/asn1_test.cc", "new_id": "640b726810063b70097fa316d525dba493f71bbb", "new_mode": 33188, "new_path": "crypto/asn1/asn1_test.cc" }, { "type": "modify", "old_id": "26634a88953c912617aa84877011240edb21aaf4", "old_mode": 33188, "old_path": "include/openssl/asn1.h", "new_id": "ff77955698987a57e9b83ed0e6b8f49ffa243ab7", "new_mode": 33188, "new_path": "include/openssl/asn1.h" } ] }