commit 2adb7ec286e870e23c4b5abd367a16bae8c5e99c
author David Benjamin <davidben@chromium.org> Sun Jan 11 19:59:06 2015 -0500
committer Adam Langley <agl@google.com> Wed Jan 14 21:48:55 2015 +0000
tree 693a750c419d12416b972acd9ff5952f6fb852ba
parent af19de31018421c3deea655dacca64211a6eb327

ssl_create_cipher_list: check whether push onto cipherstack succeeds

(Imported from upstream's f5905ba341ad0fa3731469f10f7fba6f92ecd787.)

Change-Id: I92f2f53a127a4f59ce71cf00a9a4aedd0560e586
Reviewed-on: https://boringssl-review.googlesource.com/2832
Reviewed-by: Adam Langley <agl@google.com>

ssl/ssl_ciph.c

diff --git a/ssl/ssl_ciph.c b/ssl/ssl_ciph.c
index 55323d4..60b9747 100644
--- a/ssl/ssl_ciph.c
+++ b/ssl/ssl_ciph.c
@@ -1066,7 +1066,9 @@
    * to the resulting precedence to the STACK_OF(SSL_CIPHER). */
   for (curr = head; curr != NULL; curr = curr->next) {
     if (curr->active) {
-      sk_SSL_CIPHER_push(cipherstack, curr->cipher);
+      if (!sk_SSL_CIPHER_push(cipherstack, curr->cipher)) {
+        goto err;
+      }
       in_group_flags[num_in_group_flags++] = curr->in_group;
     }
   }