tree 4e8bae6575c6ea878c4d9d914e7cf6c44ee1e3db
parent e1f8b37bee4d464c19fe958ac525236f40d25891
author Roland Shoemaker <bracewell@google.com> 1770668549 -0800
committer Boringssl LUCI CQ <boringssl-scoped@luci-project-accounts.iam.gserviceaccount.com> 1770669782 -0800

runner: syncronize shimListener connChan access

Concurrent writes and closes on a channel are a data race. The
shimListener connChan is written to by the shimDispatcher and closed by
the shimListener such that the operations can happen concurrently.

There is already a lock on shimListener to set the error and close the
channel, so reuse that lock to syncronize the writes to the channel as
well. This is slightly slower, but that should be fine. Ideally the
write and close operations would be more tightly coupled, but that would
require a more significant refactor, the shape of which is not obvious.

Change-Id: I534aebacaa3c99a18d34858fa1ca7686727fdada
Reviewed-on: https://boringssl-review.googlesource.com/c/boringssl/+/88907
Reviewed-by: David Benjamin <davidben@google.com>
Commit-Queue: David Benjamin <davidben@google.com>