| commit | 28385db6e1e480815f72f9629fa9dab48b453399 | [log] [tgz] |
|---|---|---|
| author | David Benjamin <davidben@google.com> | Sun May 06 02:08:48 2018 -0400 |
| committer | CQ bot account: commit-bot@chromium.org <commit-bot@chromium.org> | Mon May 07 19:04:00 2018 +0000 |
| tree | 57362213f337f161a6989e38c077c4a230654a58 | |
| parent | 2a92847c242376ae9213e4bafc32a62cef7e8ee9 [diff] |
Fix bssl select loop on Windows. While |WaitForMultipleObjects| works for both sockets and stdin, the latter is often a line-buffered console. The |HANDLE| is considered readable if there are any console events available, but reading blocks until a full line is available. (In POSIX, line buffering is implemented in the kernel via termios, which is differently concerning, but does mean |select| works as expected.) So that |Wait| reflects final stdin read, we spawn a stdin reader thread that writes to an in-memory buffer and signals a |WSAEVENT| to coordinate with the socket. This is kind of silly, but it works. I tried just writing it to a pipe, but it appears |WaitForMultipleObjects| does not work on pipes! Change-Id: I2bfa323fa91aad7d2035bb1fe86ee6f54b85d811 Reviewed-on: https://boringssl-review.googlesource.com/28165 Reviewed-by: Steven Valdez <svaldez@google.com> Commit-Queue: Steven Valdez <svaldez@google.com> CQ-Verified: CQ bot account: commit-bot@chromium.org <commit-bot@chromium.org>
BoringSSL is a fork of OpenSSL that is designed to meet Google's needs.
Although BoringSSL is an open source project, it is not intended for general use, as OpenSSL is. We don't recommend that third parties depend upon it. Doing so is likely to be frustrating because there are no guarantees of API or ABI stability.
Programs ship their own copies of BoringSSL when they use it and we update everything as needed when deciding to make API changes. This allows us to mostly avoid compromises in the name of compatibility. It works for us, but it may not work for you.
BoringSSL arose because Google used OpenSSL for many years in various ways and, over time, built up a large number of patches that were maintained while tracking upstream OpenSSL. As Google's product portfolio became more complex, more copies of OpenSSL sprung up and the effort involved in maintaining all these patches in multiple places was growing steadily.
Currently BoringSSL is the SSL library in Chrome/Chromium, Android (but it's not part of the NDK) and a number of other apps/programs.
There are other files in this directory which might be helpful: