commit 27ac00d2837576313da5c047d6a20e7415f3f34c
author David Benjamin <davidben@google.com> Mon Apr 21 16:36:27 2025 -0400
committer Boringssl LUCI CQ <boringssl-scoped@luci-project-accounts.iam.gserviceaccount.com> Tue Apr 22 09:16:54 2025 -0700
tree 57ea7c67b3d7d5c3b84b170ae1cfa2006c0fb2f1
parent 217e99d014841d4521a04f02d9cc36d7f80c6bb8

Add missing asserts to SSL_get_(min|max)_proto_version

It's a caller error to call those after the handshake config has been
shed. (We have an analogous pattern of asserts in other cases.)

Change-Id: Ifea0cb043a4f17e8e627d7fca81f90b8899c6587
Reviewed-on: https://boringssl-review.googlesource.com/c/boringssl/+/78827
Auto-Submit: David Benjamin <davidben@google.com>
Commit-Queue: Adam Langley <agl@google.com>
Reviewed-by: Adam Langley <agl@google.com>

ssl/ssl_versions.cc

diff --git a/ssl/ssl_versions.cc b/ssl/ssl_versions.cc
index 4ef86e9..81b5fbf 100644
--- a/ssl/ssl_versions.cc
+++ b/ssl/ssl_versions.cc
@@ -386,6 +386,7 @@
 
 uint16_t SSL_get_min_proto_version(const SSL *ssl) {
   if (!ssl->config) {
+    assert(ssl->config);
     return 0;
   }
   return ssl->config->conf_min_version;
@@ -393,6 +394,7 @@
 
 uint16_t SSL_get_max_proto_version(const SSL *ssl) {
   if (!ssl->config) {
+    assert(ssl->config);
     return 0;
   }
   return ssl->config->conf_max_version;