| commit | 251b5169fd44345f455438312ec4e18ae07fd58c | [log] [tgz] |
|---|---|---|
| author | David Benjamin <davidben@google.com> | Tue Jun 09 12:32:52 2020 -0400 |
| committer | CQ bot account: commit-bot@chromium.org <commit-bot@chromium.org> | Tue Jun 09 17:08:35 2020 +0000 |
| tree | 6bdb6c3ded3635bff8c562da35bd0c3819c4b5f6 | |
| parent | 88024df12147e56b6abd66b743ff441a0aaa09a8 [diff] |
Assert md_size > 0. md_size is the size of a hash, so it cannot be zero. Add an assert since it appears to have caused some confusion. The j >= md_size and j -= md_size logic implicitly assumes md_size > 0. (It's another way to stick a % md_size elsewhere which, likewise, assumes md_size > 0.) The bug report itself is a false positive, but locally documenting assumptions is good. Bug: chromium:1092697 Change-Id: I3be0992552a300c6786cf1dc5ecfa881173a42e6 Reviewed-on: https://boringssl-review.googlesource.com/c/boringssl/+/41544 Reviewed-by: Steven Valdez <svaldez@google.com> Reviewed-by: Adam Langley <agl@google.com> Commit-Queue: David Benjamin <davidben@google.com>
BoringSSL is a fork of OpenSSL that is designed to meet Google's needs.
Although BoringSSL is an open source project, it is not intended for general use, as OpenSSL is. We don't recommend that third parties depend upon it. Doing so is likely to be frustrating because there are no guarantees of API or ABI stability.
Programs ship their own copies of BoringSSL when they use it and we update everything as needed when deciding to make API changes. This allows us to mostly avoid compromises in the name of compatibility. It works for us, but it may not work for you.
BoringSSL arose because Google used OpenSSL for many years in various ways and, over time, built up a large number of patches that were maintained while tracking upstream OpenSSL. As Google's product portfolio became more complex, more copies of OpenSSL sprung up and the effort involved in maintaining all these patches in multiple places was growing steadily.
Currently BoringSSL is the SSL library in Chrome/Chromium, Android (but it's not part of the NDK) and a number of other apps/programs.
Project links:
There are other files in this directory which might be helpful: