)]}'
{
  "commit": "24ee260fa5979efd6f80ccdef13c5e0192ce587f",
  "tree": "d6fc147debe20ab9557af2f06b64753ed7822d3b",
  "parents": [
    "7fa475f44d7a38110c285527b9cb4900f68e3ccd"
  ],
  "author": {
    "name": "David Benjamin",
    "email": "davidben@google.com",
    "time": "Mon Apr 07 15:12:16 2025 -0400"
  },
  "committer": {
    "name": "Boringssl LUCI CQ",
    "email": "boringssl-scoped@luci-project-accounts.iam.gserviceaccount.com",
    "time": "Tue Apr 08 12:23:55 2025 -0700"
  },
  "message": "Support ANY attribute values in X509_NAME\n\nAn attribute in an X.509 name is defined as\n\n   AttributeTypeAndValue ::\u003d SEQUENCE {\n     type     AttributeType,\n     value    AttributeValue }\n\n   AttributeType ::\u003d OBJECT IDENTIFIER\n\n   AttributeValue ::\u003d ANY -- DEFINED BY AttributeType\n\nHowever, OpenSSL only supported an ad-hoc subset of types. (See\ncrbug.com/42290275 for details). Fix this by doing two things:\n\n1. Stop trying to use the MSTRING framework for AttributeValue as many\n   of these are decidedly not strings.\n\n2. Reuse ASN1_TYPE\u0027s V_ASN1_OTHER representation for non-universal tags.\n\n3. For NULL, OBJECT, and BOOLEAN, use V_ASN1_OTHER because the normal\n   representation is not an ASN1_STRING.\n\nThis is all wrapped up in a new, internal-only ASN1_ANY_AS_STRING type.\nWith this, MSTRING is no longer exposed to random unknown tags and we\ncan remove some default cases in our big switch/cases.\n\nUpdate-Note: X.509 name attributes may now be any ASN.1 type, matching\nthe spec.\n\nAdditionally, a few obscure, unimplemented ASN.1 types changed\nrepresentation: ObjectDescriptor, EXTERNAL, REAL, EMBEDDED PDV,\nRELATIVE-OID, and TIME (no connection to time types used in X.509) used\nto be represented as ASN1_STRINGs with the type fields set to the\ncorresponding tag number, and their contents uninterpreted. Now they\u0027re\nwrapped in V_ASN1_OTHER, consistent with ASN1_TYPE. This is not expected\nto impact anyone.\n\nBug: 42290275\nChange-Id: I54b0d72fcbfaeebae416aa96cdf74abdba8b4c88\nReviewed-on: https://boringssl-review.googlesource.com/c/boringssl/+/78329\nCommit-Queue: David Benjamin \u003cdavidben@google.com\u003e\nReviewed-by: Adam Langley \u003cagl@google.com\u003e\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "d2df1fbadcc7249fc8f37f126e0679aa5f48521c",
      "old_mode": 33188,
      "old_path": "crypto/asn1/asn1_test.cc",
      "new_id": "f2604acbded914de52b76aae4906d9e5dc287e5c",
      "new_mode": 33188,
      "new_path": "crypto/asn1/asn1_test.cc"
    },
    {
      "type": "modify",
      "old_id": "5732c023cf4be215383850851d59410ba9723db3",
      "old_mode": 33188,
      "old_path": "crypto/asn1/internal.h",
      "new_id": "8d863fc92d138a230bf924c378e86e6f1fbf276d",
      "new_mode": 33188,
      "new_path": "crypto/asn1/internal.h"
    },
    {
      "type": "modify",
      "old_id": "62671202e0e6812ee9e2293a6d1f53376d236bda",
      "old_mode": 33188,
      "old_path": "crypto/asn1/tasn_dec.cc",
      "new_id": "13dc114ab921fe91a05e3c4b4e109353e7a40d74",
      "new_mode": 33188,
      "new_path": "crypto/asn1/tasn_dec.cc"
    },
    {
      "type": "modify",
      "old_id": "8a5bae63989cbbe97ca1aae1554462f3cc3d0a55",
      "old_mode": 33188,
      "old_path": "crypto/asn1/tasn_enc.cc",
      "new_id": "9aa2039db482777db4af9a52a8655506105dea21",
      "new_mode": 33188,
      "new_path": "crypto/asn1/tasn_enc.cc"
    },
    {
      "type": "modify",
      "old_id": "48b0f0140e6a30ef96fc8b65e6df1527ffd4db1b",
      "old_mode": 33188,
      "old_path": "crypto/asn1/tasn_typ.cc",
      "new_id": "1d11ae890ac677c3711c30ef56abe9820ad67705",
      "new_mode": 33188,
      "new_path": "crypto/asn1/tasn_typ.cc"
    },
    {
      "type": "modify",
      "old_id": "3b7a57d5f1f48f0adad072b643bfe1c073523b7f",
      "old_mode": 33188,
      "old_path": "crypto/x509/x509_test.cc",
      "new_id": "4bed472ae4cb78e528b909447935c5ac6250b335",
      "new_mode": 33188,
      "new_path": "crypto/x509/x509_test.cc"
    },
    {
      "type": "modify",
      "old_id": "6e8e4aef66b3cbf596d2518c7975659ac814f99a",
      "old_mode": 33188,
      "old_path": "include/openssl/asn1.h",
      "new_id": "ad4905c7a87585e664c4e6e3e8bf5133f84190f5",
      "new_mode": 33188,
      "new_path": "include/openssl/asn1.h"
    }
  ]
}