)]}'
{
  "commit": "22ce9b2d08a52e399bf2ab86851952d727be034d",
  "tree": "75f68ef2ea91c766e6ca2bd9cc1aaa1fdf87c574",
  "parents": [
    "66b2fe8e0273d1f6cca5db95d4ac3979621dc4ce"
  ],
  "author": {
    "name": "David Benjamin",
    "email": "davidben@google.com",
    "time": "Sun Mar 06 19:26:52 2016 -0500"
  },
  "committer": {
    "name": "David Benjamin",
    "email": "davidben@google.com",
    "time": "Mon Mar 07 18:19:12 2016 +0000"
  },
  "message": "SSL_set_fd should create socket BIOs, not fd BIOs.\n\nIn OpenSSL, they create socket BIOs. The distinction isn\u0027t important on UNIX.\nOn Windows, file descriptors are provided by the C runtime, while sockets must\nuse separate recv and send APIs. Document how these APIs are intended to work.\n\nAlso add a TODO to resolve the SOCKET vs int thing. This code assumes that\nWindows HANDLEs only use the bottom 32 bits of precision. (Which is currently\ntrue and probably will continue to be true for the foreseeable future[*], but\nit\u0027d be nice to do this right.)\n\nThanks to Gisle Vanem and Daniel Stenberg for reporting the bug.\n\n[*] Both so Windows can continue to run 32-bit programs and because of all the\nrandom UNIX software, like OpenSSL and ourselves, out there which happily\nassumes sockets are ints.\n\nChange-Id: I67408c218572228cb1a7d269892513cda4261c82\nReviewed-on: https://boringssl-review.googlesource.com/7333\nReviewed-by: David Benjamin \u003cdavidben@google.com\u003e\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "a2f0d83ea0fe5adb830987098d47bb4d4614be26",
      "old_mode": 33188,
      "old_path": "include/openssl/bio.h",
      "new_id": "75afada9755fb17522dcef864e12bd7413a64d7a",
      "new_mode": 33188,
      "new_path": "include/openssl/bio.h"
    },
    {
      "type": "modify",
      "old_id": "be5776c7d777f7f6d4232bff712fde5b24419d88",
      "old_mode": 33188,
      "old_path": "include/openssl/ssl.h",
      "new_id": "b34fa5637d07bf58064c74b69a77d0fa2c79febc",
      "new_mode": 33188,
      "new_path": "include/openssl/ssl.h"
    },
    {
      "type": "modify",
      "old_id": "c4cc3d727dbf194a660f5360729048f52f8bfebb",
      "old_mode": 33188,
      "old_path": "ssl/ssl_lib.c",
      "new_id": "c1e6a004989c01052df7d365343e89efe6790a2d",
      "new_mode": 33188,
      "new_path": "ssl/ssl_lib.c"
    }
  ]
}
