|author||David Benjamin <firstname.lastname@example.org>||Sat Sep 22 16:49:56 2018 -0500|
|committer||Adam Langley <email@example.com>||Mon Oct 01 17:34:44 2018 +0000|
Fix undefined function pointer casts in IMPLEMENT_PEM_*. While it is okay to cast function pointers into different types for generic storage, the pointer must be cast back to the exact same type when calling. In particular, although C libraries do this sort of thing all the time, calling a T* d2i function as a void* d2i function is undefined: If the function is defined with a type that is not compatible with the type (of the expression) pointed to by the expression that denotes the called function, the behavior is undefined Fix some instances in the PEM/ASN1 wrapper functions. Synthesize helper functions instead. This CL just addresses the function pointer issues. The inherited legacy OpenSSL ASN.1 code is still full other questionable data pointer dances that will be much more difficult to excise. Continuing to exise that code altogether (it is already unshipped from Cronet and unshipped from Chrome but for WebRTC) is probably a better tack there. This removes one (of many many) places where we require -fsanitize-cfi-icall-generalize-pointers. Bug: chromium:785442 Change-Id: Id8056ead6ef471f0fdf263bb50dc659da500e8ce Reviewed-on: https://boringssl-review.googlesource.com/32105 Reviewed-by: Adam Langley <firstname.lastname@example.org> Reviewed-by: Adam Langley <email@example.com>
BoringSSL is a fork of OpenSSL that is designed to meet Google's needs.
Although BoringSSL is an open source project, it is not intended for general use, as OpenSSL is. We don't recommend that third parties depend upon it. Doing so is likely to be frustrating because there are no guarantees of API or ABI stability.
Programs ship their own copies of BoringSSL when they use it and we update everything as needed when deciding to make API changes. This allows us to mostly avoid compromises in the name of compatibility. It works for us, but it may not work for you.
BoringSSL arose because Google used OpenSSL for many years in various ways and, over time, built up a large number of patches that were maintained while tracking upstream OpenSSL. As Google's product portfolio became more complex, more copies of OpenSSL sprung up and the effort involved in maintaining all these patches in multiple places was growing steadily.
Currently BoringSSL is the SSL library in Chrome/Chromium, Android (but it's not part of the NDK) and a number of other apps/programs.
There are other files in this directory which might be helpful: