Move SendV2ClientHello to handshake coverage tests.
It's a different handshake flow with more state machine coverage. We should
make sure to test the asynchronous version.
Change-Id: I0bb79ca7e6a86bd3cac66bac1f795a885d474909
Reviewed-on: https://boringssl-review.googlesource.com/1454
Reviewed-by: Adam Langley <agl@google.com>
diff --git a/ssl/test/runner/runner.go b/ssl/test/runner/runner.go
index d8e13fb..2addab1 100644
--- a/ssl/test/runner/runner.go
+++ b/ssl/test/runner/runner.go
@@ -351,19 +351,6 @@
},
{
testType: serverTest,
- name: "SendV2ClientHello",
- config: Config{
- // Choose a cipher suite that does not involve
- // elliptic curves, so no extensions are
- // involved.
- CipherSuites: []uint16{TLS_RSA_WITH_RC4_128_SHA},
- Bugs: ProtocolBugs{
- SendV2ClientHello: true,
- },
- },
- },
- {
- testType: serverTest,
name: "FallbackSCSV",
config: Config{
MaxVersion: VersionTLS11,
@@ -1000,6 +987,23 @@
},
flags: append(flags, "-require-any-client-certificate"),
})
+
+ // Client sends a V2ClientHello.
+ testCases = append(testCases, testCase{
+ testType: serverTest,
+ name: "SendV2ClientHello",
+ config: Config{
+ // Choose a cipher suite that does not involve
+ // elliptic curves, so no extensions are
+ // involved.
+ CipherSuites: []uint16{TLS_RSA_WITH_RC4_128_SHA},
+ Bugs: ProtocolBugs{
+ MaxHandshakeRecordLength: maxHandshakeRecordLength,
+ SendV2ClientHello: true,
+ },
+ },
+ flags: flags,
+ })
}
func addVersionNegotiationTests() {
