| commit | dc0e354ac38bdaef2d8b1887733585c25a70a46e | [log] [tgz] |
|---|---|---|
| author | David Benjamin <davidben@google.com> | Wed Nov 16 23:39:44 2022 -0500 |
| committer | Boringssl LUCI CQ <boringssl-scoped@luci-project-accounts.iam.gserviceaccount.com> | Mon Nov 21 19:50:07 2022 +0000 |
| tree | edd222ba3aec8d4bda349b0a81a60d99fbc7311f | |
| parent | f0518d45119dd4dd322a884669daf8247bc3c992 [diff] |
Release memory earlier when clearing ASN1_ENCODING. ASN1_ENCODING has a 'modified' bit, but every time it is set, the contents are both ignored and never filled in again (we don't fill in the encoding except on parse). That means keeping the underlying buffer around is just wasting memory. Remove the bit and use the len != 0 to determine if there's a saved encoding. Replace all the modified bits with a helper function that drops the encoding. I don't think we need a separate "present" boolean and can just treat empty as not saved; a cached value always has a tag and length, so it cannot be empty. (Even if it could be empty, that would imply the value's encoding is trivial enough that we probably don't need the saved encoding to preserve the value.) Change-Id: I6beda94d33f3799daf85f1397818b9a41e7dd18a Reviewed-on: https://boringssl-review.googlesource.com/c/boringssl/+/55267 Commit-Queue: Adam Langley <agl@google.com> Auto-Submit: David Benjamin <davidben@google.com> Reviewed-by: Adam Langley <agl@google.com>
BoringSSL is a fork of OpenSSL that is designed to meet Google's needs.
Although BoringSSL is an open source project, it is not intended for general use, as OpenSSL is. We don't recommend that third parties depend upon it. Doing so is likely to be frustrating because there are no guarantees of API or ABI stability.
Programs ship their own copies of BoringSSL when they use it and we update everything as needed when deciding to make API changes. This allows us to mostly avoid compromises in the name of compatibility. It works for us, but it may not work for you.
BoringSSL arose because Google used OpenSSL for many years in various ways and, over time, built up a large number of patches that were maintained while tracking upstream OpenSSL. As Google's product portfolio became more complex, more copies of OpenSSL sprung up and the effort involved in maintaining all these patches in multiple places was growing steadily.
Currently BoringSSL is the SSL library in Chrome/Chromium, Android (but it's not part of the NDK) and a number of other apps/programs.
Project links:
There are other files in this directory which might be helpful: