| commit | 1db42fb3ca46d3d4987ddae2f7aec7732c66a70b | [log] [tgz] |
|---|---|---|
| author | David Benjamin <davidben@google.com> | Fri Aug 19 16:08:45 2016 -0400 |
| committer | CQ bot account: commit-bot@chromium.org <commit-bot@chromium.org> | Fri Aug 26 17:48:48 2016 +0000 |
| tree | e50a56e8ef1cd6561f4d6e05ebf51573cc3bfc3d | |
| parent | a6cd185a545841d122d8f0a49c2cffdabab149b7 [diff] |
Clarify CBS/CBB with respect to high tag number form. We may need to implement high tag number form someday. CBS_get_asn1 has an unsigned output to allow for this, but CBB_add_asn1 takes a uint8_t (I think this might be my fault). Fix that which also fixes a -Wconversion warning. Simply leaving room in tag representation will still cause troubles because the class and constructed bits overlap with bits for tag numbers above 31. Probably the cleanest option would be to shift them to the top 3 bits of a u32 and thus not quite match the DER representation. Then CBS_get_asn1 and CBB_add_asn1 will internally munge that into the DER representation and consumers may continue to write things like: tag_number | CBS_ASN1_CONTEXT_SPECIFIC I haven't done that here, but in preparation for that, document that consumers need to use the values and should refrain from assuming the correspond to DER. Change-Id: Ibc76e51f0bc3b843e48e89adddfe2eaba4843d12 Reviewed-on: https://boringssl-review.googlesource.com/10502 Reviewed-by: Adam Langley <agl@google.com> Commit-Queue: Adam Langley <agl@google.com> CQ-Verified: CQ bot account: commit-bot@chromium.org <commit-bot@chromium.org>
BoringSSL is a fork of OpenSSL that is designed to meet Google's needs.
Although BoringSSL is an open source project, it is not intended for general use, as OpenSSL is. We don't recommend that third parties depend upon it. Doing so is likely to be frustrating because there are no guarantees of API or ABI stability.
Programs ship their own copies of BoringSSL when they use it and we update everything as needed when deciding to make API changes. This allows us to mostly avoid compromises in the name of compatibility. It works for us, but it may not work for you.
BoringSSL arose because Google used OpenSSL for many years in various ways and, over time, built up a large number of patches that were maintained while tracking upstream OpenSSL. As Google's product portfolio became more complex, more copies of OpenSSL sprung up and the effort involved in maintaining all these patches in multiple places was growing steadily.
Currently BoringSSL is the SSL library in Chrome/Chromium, Android (but it's not part of the NDK) and a number of other apps/programs.
There are other files in this directory which might be helpful: