)]}'
{
  "commit": "1c9d18307bdf75bee7f3ec7f7d2e421a734831f1",
  "tree": "15798896c292b4d76edd6fa176f2e6f5bd95e8ed",
  "parents": [
    "ae1546b6f3bf1ad7eb24b491c914eb202b5547d3"
  ],
  "author": {
    "name": "David Benjamin",
    "email": "davidben@google.com",
    "time": "Mon Jan 23 10:36:30 2023 -0500"
  },
  "committer": {
    "name": "Boringssl LUCI CQ",
    "email": "boringssl-scoped@luci-project-accounts.iam.gserviceaccount.com",
    "time": "Mon Jan 23 16:29:23 2023 +0000"
  },
  "message": "Don\u0027t automatically sync the two CONF parameters in X509V3_EXT_nconf.\n\nhttps://boringssl-review.googlesource.com/c/boringssl/+/56109 tried to\nsimplify the X509V3_CTX story by automatically handling the second half\nof initialization, but it turns out not all callers specify both values.\n\nInstead, align with OpenSSL 3.0\u0027s behavior. Now X509V3_set_ctx\nimplicitly zeros the other fields, so it is the only mandatory init\nfunction. This does mean callers which call X509V3_set_nconf before\nX509V3_set_ctx will break, but that\u0027s true in OpenSSL 3.0 too.\n\nI\u0027ve retained the allowance for ctx being NULL, because whether\nfunctions tolerate that or not is still a bit inconsistent. Also added\nsome TODOs about how strange this behavior is, but it\u0027s probably not\nworth spending much more time on this code.\n\nChange-Id: Ia04cf11eb5158374ca186795b7e579575e80666f\nReviewed-on: https://boringssl-review.googlesource.com/c/boringssl/+/56265\nReviewed-by: Adam Langley \u003cagl@google.com\u003e\nAuto-Submit: David Benjamin \u003cdavidben@google.com\u003e\nCommit-Queue: Adam Langley \u003cagl@google.com\u003e\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "32b2483ad8ac14318d66d8e5848cebd06afe9ad8",
      "old_mode": 33188,
      "old_path": "crypto/x509/x509_test.cc",
      "new_id": "93dccdab80639573fd151d586e8982022a87c18c",
      "new_mode": 33188,
      "new_path": "crypto/x509/x509_test.cc"
    },
    {
      "type": "modify",
      "old_id": "b784954ededf20878de173e450f70c512e174403",
      "old_mode": 33188,
      "old_path": "crypto/x509v3/v3_conf.c",
      "new_id": "3261302cfa82cac380fc7131f6b6d6ca39c012cd",
      "new_mode": 33188,
      "new_path": "crypto/x509v3/v3_conf.c"
    },
    {
      "type": "modify",
      "old_id": "530444b92c8d451c914bd08bd416f58a1d289db3",
      "old_mode": 33188,
      "old_path": "include/openssl/x509v3.h",
      "new_id": "37e1a2273aec900f43e1186a2ce4a9373918c52b",
      "new_mode": 33188,
      "new_path": "include/openssl/x509v3.h"
    }
  ]
}