tree e9ed9602f866048b71c7994707e5730bc4bb6e3e
parent a697bcb71dc1b822e681fc3defb61786f6c26c2e
author David Benjamin <davidben@google.com> 1699802276 -0500
committer Boringssl LUCI CQ <boringssl-scoped@luci-project-accounts.iam.gserviceaccount.com> 1700581231 +0000

Unexport some ASN1_ITEMs that aren't used externally

The only ASN1_ITEMs from x509.h that are referenced externally are
X509_NAME, X509_ALGOR, and RSA_PSS_PARAMS. (RSA_PSS_PARAMS only by way
of an ASN1_item_pack call.) The others don't actually need ASN1_ITEMs.
This will cut down on the number of compatibility schemes we need when
the parsers are rewritten.

Also remove (d2i|i2d)_X509_NAME_ENTRY. It seems people only need to
create and destroy them, not serialize them individually.

It also means we can actually remove X509's ASN1_ITEM, as it's already
unused inside the library. I've replaced EmbedX509 with tests for the
types that are actually embedded. Those have not yet been rewritten,
but the tests are now ready for when they are.

Update-Note: Fewer types can be parsed generically through the ASN1_ITEM
system now. If someone was relying on a removed ASN1_ITEM, it will
appear as a compile error and we can restore it.

Bug: 443
Change-Id: Ib2a75d40c2e93dcf1c0474cf0df4a96190aac9a4
Reviewed-on: https://boringssl-review.googlesource.com/c/boringssl/+/63946
Reviewed-by: Bob Beck <bbe@google.com>
Commit-Queue: David Benjamin <davidben@google.com>