rust: bssl-tls: Disallow downcasting in-handshake to normal handle A big downside in doing so is that it accidentally allows users to trigger progression in TLS state machine during the handshake. This is possible because we supply various callbacks with the in-handshake handle and through this existing downcasting the callbacks can call read and write again, which is a re-entry into our handshake code. Update-Note: a breaking change is introduced to further restrict the `in_handshake()` handle to the connection, so that one cannot possibly advance the TLS state machine while a read or write into the TLS socket is in progress. This was possible through callbacks that can be invoked while reading or writing on the socket. The necessary changes can be found in cl/934247882. Signed-off-by: Xiangfei Ding <xfding@google.com> Change-Id: I3212b0184a3ebda606812217a4e350396a6a6964 Reviewed-on: https://boringssl-review.googlesource.com/c/boringssl/+/97667 Presubmit-BoringSSL-Verified: boringssl-scoped@luci-project-accounts.iam.gserviceaccount.com <boringssl-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: David Benjamin <davidben@google.com>
BoringSSL is a fork of OpenSSL that is designed to meet Google's needs.
Although BoringSSL is an open source project, it is not intended for general use, as OpenSSL is. We don't recommend that third parties depend upon it. Doing so is likely to be frustrating because there are no guarantees of API or ABI stability.
Programs ship their own copies of BoringSSL when they use it and we update everything as needed when deciding to make API changes. This allows us to mostly avoid compromises in the name of compatibility. It works for us, but it may not work for you.
BoringSSL arose because Google used OpenSSL for many years in various ways and, over time, built up a large number of patches that were maintained while tracking upstream OpenSSL. As Google's product portfolio became more complex, more copies of OpenSSL sprung up and the effort involved in maintaining all these patches in multiple places was growing steadily.
Currently BoringSSL is the SSL library in Chrome/Chromium, Android (but it's not part of the NDK) and a number of other apps/programs.
Project links:
To file a security issue, use the Chromium process and mention in the report this is for BoringSSL. You can ignore the parts of the process that are specific to Chromium/Chrome.
There are other files in this directory which might be helpful: