)]}'
{
  "commit": "17078f21a514d74e6eaaf402ca1f6982ec2651fd",
  "tree": "e381e4049800829de8a770ca6a998bb6e71c32ad",
  "parents": [
    "dc06e320d88db2f2a49deaae33c9e54f1b68e42b"
  ],
  "author": {
    "name": "David Benjamin",
    "email": "davidben@google.com",
    "time": "Tue Apr 28 17:50:13 2020 -0400"
  },
  "committer": {
    "name": "CQ bot account: commit-bot@chromium.org",
    "email": "commit-bot@chromium.org",
    "time": "Fri May 01 17:29:22 2020 +0000"
  },
  "message": "Fix the types used in token counts.\n\nThe number of tokens is inconsistent throughout the API. max_batchsize\nis a uint16_t. max_issuance is a size_t. out_tokens_issued is a\nuint8_t*. The serialization only supports up to uint16_t.\n\nStandardize on size_t. The natural size for a count of elements is\nsize_t. Protocol limitations can be handled within the implementation.\nAdditionally, it is best not to use small types for counters in public\nAPIs in C/C++ because the language has implicit truncating conversions.\n(Whereas code points or other enum-like values are fine because the\ncaller won\u0027t managed to get a 32-bit cipher suite.)\n\nUpdate-Note: Fix callers of TRUST_TOKEN_ISSUER_issue to use size_t\ninstead of uint8_t. The max_batchsize changes should go through without\nchanges to the caller.\n\nChange-Id: I9be5dd8f61abdbe5a1dbe70b8dc72d06114b1022\nReviewed-on: https://boringssl-review.googlesource.com/c/boringssl/+/41044\nCommit-Queue: Steven Valdez \u003csvaldez@google.com\u003e\nReviewed-by: Steven Valdez \u003csvaldez@google.com\u003e\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "08040f5f14880b1965d3fb552c9ca9c9fd748e74",
      "old_mode": 33188,
      "old_path": "crypto/trust_token/trust_token.c",
      "new_id": "6f5756a6bd0098f5c5ee7339d0677487d4e661c7",
      "new_mode": 33188,
      "new_path": "crypto/trust_token/trust_token.c"
    },
    {
      "type": "modify",
      "old_id": "ce832dbb0e738e405b4fec3a84ef99eecd8f56da",
      "old_mode": 33188,
      "old_path": "crypto/trust_token/trust_token_test.cc",
      "new_id": "2da8b08a088028fa11f89966c4a8a174fce807a8",
      "new_mode": 33188,
      "new_path": "crypto/trust_token/trust_token_test.cc"
    },
    {
      "type": "modify",
      "old_id": "8bd1edae5b0f51d011f136fab2044a9645981123",
      "old_mode": 33188,
      "old_path": "include/openssl/trust_token.h",
      "new_id": "008857eef9c6d75b2e17713b2b1ab87b4987d2cc",
      "new_mode": 33188,
      "new_path": "include/openssl/trust_token.h"
    },
    {
      "type": "modify",
      "old_id": "c91c25b0a89c226b8cf6ab395ed5e56af2a8fe95",
      "old_mode": 33188,
      "old_path": "tool/speed.cc",
      "new_id": "b1f530d125d1bf235adffed5e0d3b398949e8d6b",
      "new_mode": 33188,
      "new_path": "tool/speed.cc"
    }
  ]
}