)]}' { "commit": "15e4deb1658f95a318a5aa0ce210c7ecff639652", "tree": "f82b91f1679f990d239d8781570b64eaa71fce98", "parents": [ "97a33939a38ad5e9f0e89c39de245e3a8326b96b" ], "author": { "name": "David Benjamin", "email": "davidben@chromium.org", "time": "Sat Sep 19 14:13:50 2015 -0400" }, "committer": { "name": "Adam Langley", "email": "agl@google.com", "time": "Mon Sep 28 22:15:17 2015 +0000" }, "message": "d2i: don\u0027t update input pointer on failure\n\n(Imported from upstream\u0027s 728bcd59d3d41e152aead0d15acc51a8958536d3.)\n\nActually this one was reported by us, but the commit message doesn\u0027t\nmention this.\n\nThis is slightly modified from upstream\u0027s version to fix some problems\nnoticed in import. Specifically one of d2i_X509_AUX\u0027s success paths is\nbust and d2i_PrivateKey still updates on one error path. Resolve the\nlatter by changing both it and d2i_AutoPrivateKey to explicitly hit the\nerror path on ret \u003d\u003d NULL. This lets us remove the NULL check in\nd2i_AutoPrivateKey.\n\nWe\u0027ll want to report the problems back upstream.\n\nChange-Id: Ifcfc965ca6d5ec0a08ac154854bd351cafbaba25\nReviewed-on: https://boringssl-review.googlesource.com/5948\nReviewed-by: Adam Langley \u003cagl@google.com\u003e\n", "tree_diff": [ { "type": "modify", "old_id": "507a8424b0074632814310aeceb9416539bd9080", "old_mode": 33188, "old_path": "crypto/asn1/tasn_dec.c", "new_id": "d852ad7b660d734f9881ca621f9acd4d4d7da446", "new_mode": 33188, "new_path": "crypto/asn1/tasn_dec.c" }, { "type": "modify", "old_id": "31d89448d1726860fa8f73d08f4457fe331f94b8", "old_mode": 33188, "old_path": "crypto/ec/ec_asn1.c", "new_id": "f540256364d79cc2853550ca2490d5c6db20c54a", "new_mode": 33188, "new_path": "crypto/ec/ec_asn1.c" }, { "type": "modify", "old_id": "356c62b8084fa0f12eaffd28037d44f59833cce1", "old_mode": 33188, "old_path": "crypto/evp/evp_asn1.c", "new_id": "08956e1d87ae2ec544338c6785b3f80bfc504c6d", "new_mode": 33188, "new_path": "crypto/evp/evp_asn1.c" }, { "type": "modify", "old_id": "c975dd35038dad23efb92bca7464bbb5fc673baf", "old_mode": 33188, "old_path": "crypto/x509/x_x509.c", "new_id": "b8f318a0436378e6655cfa518ce935a28742602d", "new_mode": 33188, "new_path": "crypto/x509/x_x509.c" } ] }