)]}'
{
  "commit": "1500ad0533fa43ea27ffb1338b96e352d3706dc7",
  "tree": "5288d99040cf5e1a4deddc52277e6a15345c2d8f",
  "parents": [
    "955ef7991e41ac6c0ea5114b4b9abb98cc5fd614"
  ],
  "author": {
    "name": "David Benjamin",
    "email": "davidben@google.com",
    "time": "Mon Jun 13 12:33:07 2022 -0400"
  },
  "committer": {
    "name": "Boringssl LUCI CQ",
    "email": "boringssl-scoped@luci-project-accounts.iam.gserviceaccount.com",
    "time": "Wed Jun 15 18:16:52 2022 +0000"
  },
  "message": "Define STACK_OF(OPENSSL_STRING) more straight-forwardly.\n\nThis results in one change, which is the comparison function goes from:\n\n  typedef char *OPENSSL_STRING;\n  static int sk_strcmp(const OPENSSL_STRING *a,\n                       const OPENSSL_STRING *b);\n\nwhich is:\n\n  static int sk_strcmp(char *const *a, char *const *b)\n\ninto:\n\n  static int sk_strcmp(const char **a, const char **b)\n\nNeither is correct (both consts should be there), but switching the\ndefintion is necessary to attach the \u0027const\u0027 to \u0027char\u0027 itself. Otherwise\nit wouldn\u0027t see through the typedef. Fixing the rest of the calling\nconvention will finish the job. Plan there is, when\nI00d13c949a535c0d60873fe4ba2e5604bb585cca lands, I\u0027ll switch Envoy to\ncall that. Then we should be clear to const-correct the callback.\n\n(While STACK_OF(OPENSSL_STRING) is used externally, nothing external\ntouches the comparison function.)\n\nBug: 498\nChange-Id: I77bdf2a72b2553bf9409a1d39326890ed5c3582c\nReviewed-on: https://boringssl-review.googlesource.com/c/boringssl/+/53008\nReviewed-by: Adam Langley \u003cagl@google.com\u003e\nCommit-Queue: David Benjamin \u003cdavidben@google.com\u003e\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "064e71b9fa99e24dd9985e2035381c8d15eca8d3",
      "old_mode": 33188,
      "old_path": "crypto/x509v3/v3_utl.c",
      "new_id": "bf5ef529d11ac9ced3182b81639a8b01640c33de",
      "new_mode": 33188,
      "new_path": "crypto/x509v3/v3_utl.c"
    },
    {
      "type": "modify",
      "old_id": "87403678a3d56c2b64695f4ebf8189c5def09bc1",
      "old_mode": 33188,
      "old_path": "include/openssl/stack.h",
      "new_id": "7b95f34666b313c56543c4fba6c63cf95985e12f",
      "new_mode": 33188,
      "new_path": "include/openssl/stack.h"
    }
  ]
}