| commit | 141062fe7f9aa4e1b9a1a3d2f59489eefcff4df8 | [log] [tgz] |
|---|---|---|
| author | David Benjamin <davidben@google.com> | Fri Feb 28 17:12:13 2020 -0500 |
| committer | CQ bot account: commit-bot@chromium.org <commit-bot@chromium.org> | Tue Mar 31 23:11:26 2020 +0000 |
| tree | ecb2ae67d4839ff82e665be7287e49183ef631d4 | |
| parent | ce9b8737cb3e113c9f986d6a94aeedb09e8207b2 [diff] |
Remove LCM dependency from RSA_check_key. Instead of checking d * e = 1 (mod lcm(p-1, q-1)), we can separately check d * e = 1 (mod p-1) and d * e = 1 (mod q-1). This drops an LCM dependency from key import and is 2x faster. (Our constant-time LCM implementation can probably be faster if we tried, but now it's only used in RSA keygen, so it doesn't matter much. It's also using the unoptimized constant-time division, which is probably the next target if we decide we care about speeding this up.) Before: Did 6768 RSA 2048 checking operations in 3015824us (2244.2 ops/sec) Did 5610 RSA 2048 signing operations in 3033396us (1849.4 ops/sec) Did 1953 RSA 4096 checking operations in 3060828us (638.1 ops/sec) Did 817 RSA 4096 signing operations in 3021092us (270.4 ops/sec) After: Did 13175 RSA 2048 checking operations in 3090576us (4263.0 ops/sec) Did 5610 RSA 2048 signing operations in 3032966us (1849.7 ops/sec) Did 3720 RSA 4096 checking operations in 3085971us (1205.5 ops/sec) Did 820 RSA 4096 signing operations in 3027312us (270.9 ops/sec) Bug: 316 Change-Id: Ie29554c02d31f586dd0f8bdee03a227f1d5dc916 Reviewed-on: https://boringssl-review.googlesource.com/c/boringssl/+/40146 Commit-Queue: Adam Langley <agl@google.com> Reviewed-by: Adam Langley <agl@google.com>
BoringSSL is a fork of OpenSSL that is designed to meet Google's needs.
Although BoringSSL is an open source project, it is not intended for general use, as OpenSSL is. We don't recommend that third parties depend upon it. Doing so is likely to be frustrating because there are no guarantees of API or ABI stability.
Programs ship their own copies of BoringSSL when they use it and we update everything as needed when deciding to make API changes. This allows us to mostly avoid compromises in the name of compatibility. It works for us, but it may not work for you.
BoringSSL arose because Google used OpenSSL for many years in various ways and, over time, built up a large number of patches that were maintained while tracking upstream OpenSSL. As Google's product portfolio became more complex, more copies of OpenSSL sprung up and the effort involved in maintaining all these patches in multiple places was growing steadily.
Currently BoringSSL is the SSL library in Chrome/Chromium, Android (but it's not part of the NDK) and a number of other apps/programs.
Project links:
There are other files in this directory which might be helpful: