| commit | 10a76acb0f2564a525887f88c4e3aea10f3fc1f2 | [log] [tgz] |
|---|---|---|
| author | David Benjamin <davidben@google.com> | Wed Jun 16 11:33:37 2021 -0400 |
| committer | Boringssl LUCI CQ <boringssl-scoped@luci-project-accounts.iam.gserviceaccount.com> | Wed Jun 23 20:04:59 2021 +0000 |
| tree | 8a064e84cf9ed60775157245d8a30907a1211b36 | |
| parent | afa867be8f6dce3e416b8e5f54013cbf970b5609 [diff] |
Only clear not_resumable after the handshake. In renegotiation handshakes and, later, ECH ClientHelloOuter handshakes, we don't want to add sessions to the session cache. We also don't want to release a session as resumable until the handshake completes. Ideally we'd only construct SSL_SESSION at the end of the handshake, but existing APIs like SSL_get_session must work mid-handshake, so SSL_SESSION is both a handle to immutable resumption state, and a container for in-progress connection properties. We manage this with a not_resumable flag that's only cleared after the handshake is done and the SSL_SESSION finalized. However, TLS 1.2 ticket renewal currently clears the flag too early and breaks the invariant. This won't actually affect renegotiation or ClientHelloOuter because those handshakes never resume. Still, we can maintain the invariant storing the copy in hs->new_session. Note this does sacrifice a different invariant: previously, ssl->session and hs->new_session were never set at the same time. This change also means ssl_update_cache does not need to special-case ticket renewal. Change-Id: I03230cd9c63e5bee6bd60cd05c0439e16533c6d4 Reviewed-on: https://boringssl-review.googlesource.com/c/boringssl/+/48132 Commit-Queue: David Benjamin <davidben@google.com> Reviewed-by: Adam Langley <agl@google.com>
BoringSSL is a fork of OpenSSL that is designed to meet Google's needs.
Although BoringSSL is an open source project, it is not intended for general use, as OpenSSL is. We don't recommend that third parties depend upon it. Doing so is likely to be frustrating because there are no guarantees of API or ABI stability.
Programs ship their own copies of BoringSSL when they use it and we update everything as needed when deciding to make API changes. This allows us to mostly avoid compromises in the name of compatibility. It works for us, but it may not work for you.
BoringSSL arose because Google used OpenSSL for many years in various ways and, over time, built up a large number of patches that were maintained while tracking upstream OpenSSL. As Google's product portfolio became more complex, more copies of OpenSSL sprung up and the effort involved in maintaining all these patches in multiple places was growing steadily.
Currently BoringSSL is the SSL library in Chrome/Chromium, Android (but it's not part of the NDK) and a number of other apps/programs.
Project links:
There are other files in this directory which might be helpful: