Google Git
Sign in
boringssl / boringssl / 567272392b34466443677c08c63183bcd365f7e8
commit567272392b34466443677c08c63183bcd365f7e8[log] [tgz]
authorRudolf Polzer <rpolzer@google.com>Mon Nov 10 02:23:55 2025 -0800
committerBoringssl LUCI CQ <boringssl-scoped@luci-project-accounts.iam.gserviceaccount.com>Mon Nov 10 09:36:55 2025 -0800
tree402572d54aabdc0f51c28a1f58503c9422717c8a
parentec4fb365a92dc0dff7370aae5d68642338b48ff5 [diff]
EVP_Cipher: fix comments about required buffer sizes.

Since Id662e4274f01e0ea95ce5a944943bd4258fe8f06, EVP_DecryptUpdate, in
case of ending at an exact block size multiple, no longer first decrypts
the final block into the output buffer only to then cut it out and paste
it to the internal buffer for the final block; instead, it decrypts the
final block into the internal buffer right away.

This means that both encryption and decryption now need at most
block_size-1 additional bytes in the output buffer. Encryption maxes it
out when updating by one byte fills an entire cipher block; decryption
OTOH maxes it out when updating by one byte after the previous call
ended at a block boundary.

Updated both the comment and the internal legacy wrappers, to ensure
that tests cover the modified bounds.

Bug: 42290361
Change-Id: Iba8df8286c752101ee83cc151295b2d7ed9b137f
Reviewed-on: https://boringssl-review.googlesource.com/c/boringssl/+/83887
Reviewed-by: David Benjamin <davidben@google.com>
Commit-Queue: David Benjamin <davidben@google.com>
Auto-Submit: Rudolf Polzer <rpolzer@google.com>
2 files changed
tree: 402572d54aabdc0f51c28a1f58503c9422717c8a
  1. .bcr/
  2. .github/
  3. cmake/
  4. crypto/
  5. decrepit/
  6. docs/
  7. fuzz/
  8. gen/
  9. include/
  10. infra/
  11. pki/
  12. rust/
  13. ssl/
  14. third_party/
  15. tool/
  16. util/
  17. .bazelignore
  18. .bazelrc
  19. .bazelversion
  20. .clang-format
  21. .clang-format-ignore
  22. .gitignore
  23. API-CONVENTIONS.md
  24. AUTHORS
  25. BREAKING-CHANGES.md
  26. BUILD.bazel
  27. build.json
  28. BUILDING.md
  29. CMakeLists.txt
  30. codereview.settings
  31. CONTRIBUTING.md
  32. FUZZING.md
  33. go.mod
  34. go.sum
  35. INCORPORATING.md
  36. LICENSE
  37. MODULE.bazel
  38. MODULE.bazel.lock
  39. PORTING.md
  40. PRESUBMIT.py
  41. PrivacyInfo.xcprivacy
  42. README.md
  43. SANDBOXING.md
  44. STYLE.md
README.md

BoringSSL

BoringSSL is a fork of OpenSSL that is designed to meet Google's needs.

Although BoringSSL is an open source project, it is not intended for general use, as OpenSSL is. We don't recommend that third parties depend upon it. Doing so is likely to be frustrating because there are no guarantees of API or ABI stability.

Programs ship their own copies of BoringSSL when they use it and we update everything as needed when deciding to make API changes. This allows us to mostly avoid compromises in the name of compatibility. It works for us, but it may not work for you.

BoringSSL arose because Google used OpenSSL for many years in various ways and, over time, built up a large number of patches that were maintained while tracking upstream OpenSSL. As Google's product portfolio became more complex, more copies of OpenSSL sprung up and the effort involved in maintaining all these patches in multiple places was growing steadily.

Currently BoringSSL is the SSL library in Chrome/Chromium, Android (but it's not part of the NDK) and a number of other apps/programs.

Project links:

To file a security issue, use the Chromium process and mention in the report this is for BoringSSL. You can ignore the parts of the process that are specific to Chromium/Chrome.

There are other files in this directory which might be helpful: