)]}' { "commit": "09a9ec036030ac84896f5143548d05f3951d1817", "tree": "dd1f7aa65cbaf61896316c54d0a7537e12052484", "parents": [ "6e8d5f4a4f72a3d81fe26eb42858e481b5e95869" ], "author": { "name": "Pete Bentley", "email": "prb@google.com", "time": "Fri Sep 20 20:29:05 2019 +0100" }, "committer": { "name": "Adam Langley", "email": "agl@google.com", "time": "Mon Sep 23 15:50:35 2019 +0000" }, "message": "Add page protection logic to BCM self test.\n\nOn Android only, assume code is compiled for Execute-only memory, so add\nRead permission for the duration of the self test and\nthen mark the pages Execute-only again.\n\nNB if libcrypto is not compiled for Execute-only memory, then attempting\nto change the page permissions to PROT_EXEC at the start of the self\ntest does not cause it to fail, however changing it to PROT_NONE does.\n\nBug: 134580074\nTest: m \u0026\u0026 flashall\nTest: Manual tests described above.\n\nChange-Id: Ibbf8405a5a9b162ce26532127aaf62c539cd9163\nReviewed-on: https://boringssl-review.googlesource.com/c/boringssl/+/37644\nCommit-Queue: Adam Langley \u003cagl@google.com\u003e\nReviewed-by: Adam Langley \u003cagl@google.com\u003e\n", "tree_diff": [ { "type": "modify", "old_id": "559ade3475d1a706de3e15e7ce5d7d2d062e8b3e", "old_mode": 33188, "old_path": "crypto/fipsmodule/bcm.c", "new_id": "54f113bbf56b5a74d35433bbd63e9e30dfbdcc90", "new_mode": 33188, "new_path": "crypto/fipsmodule/bcm.c" } ] }