commit 08791e6756c3fbee0ef1bdc104a74ab212501bb6
author David Benjamin <davidben@google.com> Thu Mar 10 12:41:19 2016 -0500
committer David Benjamin <davidben@google.com> Thu Mar 10 19:08:42 2016 +0000
tree 16ee0dfb1de5777077a65876a547e66696bf258b
parent 97c80512afc7ff8d0afcc806ef6dd936cca752a2

Appease sanitizers in x25519_ge_scalarmult.

Although exactly one iteration of cmov_cached will always initialize selected,
it ends up messing with uninitialized memory. Initialize |selected| before the
loop.

BUG=593540

Change-Id: I5921843f68c6dd1dc7f752538825bc43ba75df4a
Reviewed-on: https://boringssl-review.googlesource.com/7415
Reviewed-by: Arnar Birgisson <arnarb@google.com>
Reviewed-by: David Benjamin <davidben@google.com>

crypto/curve25519/curve25519.c

diff --git a/crypto/curve25519/curve25519.c b/crypto/curve25519/curve25519.c
index 556b455..1dd1b3e 100644
--- a/crypto/curve25519/curve25519.c
+++ b/crypto/curve25519/curve25519.c
@@ -3606,6 +3606,7 @@
 
     unsigned j;
     ge_cached selected;
+    ge_cached_0(&selected);
     for (j = 0; j < 16; j++) {
       cmov_cached(&selected, &Ai[j], equal(j, index));
     }