tree f80f2ca34a7a71608a5f4119d2e0ac4bc50803c3
parent 26111abe5ba1546ed41a8940a609c58445b853c0
author David Benjamin <davidben@google.com> 1756320565 -0400
committer Boringssl LUCI CQ <boringssl-scoped@luci-project-accounts.iam.gserviceaccount.com> 1756957977 -0700

Make CBS/CBB-versions of crypto/asn1 types

I had hoped to do this incrementally, but X509_ALGOR contains an
ASN1_TYPE, so all types get imported at once. For now, these functions
are just wired up to tasn_dec.cc, but subsequent changes will read them
one-by-one.

For the parse convention, I opted for a caller-supplied output variable,
even though we've generally tried to avoid object reuse in the
caller-exposed d2i functions. At the level of core ASN.1 types, the
object reuse is hopefully manageable (and in practice I expect they'll
always be in the empty state). The motivation here is to let us
internally embed types into the X509, etc., structs and avoid the layers
of tiny allocations.

This does mean that the dispatch code inside ASN1_TYPE and the dispatch
code in tasn_dec.cc is no longer shared, but that sharing wasn't valid
by strict aliasing anyway. (Nothing in tasn_dec.cc is valid by strict
aliasing.)

Bug: 42290417
Change-Id: Idb6910e23f4fa4d01ee39ebcbf2ae09df14e87e3
Reviewed-on: https://boringssl-review.googlesource.com/c/boringssl/+/81772
Reviewed-by: Adam Langley <agl@google.com>
Commit-Queue: David Benjamin <davidben@google.com>