tree 0191e85c49d2f8e125bcf48c6c800b5da71768b9
parent 2c58c2fda1c1da4131f35f58289f44d87cedbb8d
author David Benjamin <davidben@google.com> 1577999248 -0500
committer CQ bot account: commit-bot@chromium.org <commit-bot@chromium.org> 1578337812 +0000

Remove alignment requirement on CRYPTO_poly1305_finish.

This dates to https://boringssl-review.googlesource.com/2850, which was
done in response to an ARM crash. I assume the ARM crash was due to
poly1305_arm.c casting pointers around, which is technically UB, even on
x86 since C says it is UB to cast pointers if the value would be
unaligned. (Also I believe it's a strict aliasing violation, though the
compilers really ought to give us a sanitizer for it if they're excited
about that optimization.)

Replace with memcpy, which any reasonable compiler would compile the
same on platforms that support unaligned access. ARM does support it
these days, so perhaps the crash came from an older ARM?

Benchmarks showed no difference with this CL.

Change-Id: I022bdb84f95e45c143ad19359f646ee1416d5ae9
Reviewed-on: https://boringssl-review.googlesource.com/c/boringssl/+/39344
Commit-Queue: Adam Langley <agl@google.com>
Reviewed-by: Adam Langley <agl@google.com>