Google Git
Sign in
boringssl/boringssl/04aa32f96f3094994a2971d703f7489b75b94f84
commit
04aa32f96f3094994a2971d703f7489b75b94f84
[log]
author
David Benjamin <davidben@google.com>
Sat Apr 25 20:01:45 2026 -0400
committer
boringssl-scoped@luci-project-accounts.iam.gserviceaccount.com <boringssl-scoped@luci-project-accounts.iam.gserviceaccount.com>
Tue Apr 28 15:42:49 2026 -0700
tree
637d39027dc61f21db0567c8e1b72e07d3c04fc2
parent
ac5067e905a42b4a5e608d821a837805f94f295f [diff]
Fix the legacy AES-GCM API's IV resizing logic

With the right sequence of resizes and copies, aes_gcm_ctrl breaks the
invariant that IV lengths below EVP_MAX_IV_LENGTH stay in the built-in
buffer and things get confused. Fix this by maintaining the invariant
more strongly.

This is not expected to impact any actual callers as there is no reason
to repeatedly change the IV length like this. And as this is not an
intrinsic part of the primitive, just extremely weird OpenSSL API
decisions, it's also unlikely this API was directly transcribed to some
kind of untrusted execution environment like JavaScript.

(There is also no reason to change AES-GCM's IV length. That was a NIST
mistake.)

Change-Id: I87df7764b9c1e7ee3ac524e8b70ee70d8a7ff16e
Reviewed-on: https://boringssl-review.googlesource.com/c/boringssl/+/94087
Auto-Submit: David Benjamin <davidben@google.com>
Presubmit-BoringSSL-Verified: boringssl-scoped@luci-project-accounts.iam.gserviceaccount.com <boringssl-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Xiangfei Ding <xfding@google.com>
Commit-Queue: Xiangfei Ding <xfding@google.com>
2 files changed
tree: 637d39027dc61f21db0567c8e1b72e07d3c04fc2
  1. .bcr/
  2. .github/
  3. bench/
  4. cmake/
  5. crypto/
  6. decrepit/
  7. docs/
  8. fuzz/
  9. gen/
  10. include/
  11. infra/
  12. pki/
  13. rust/
  14. ssl/
  15. third_party/
  16. tool/
  17. util/
  18. .bazelignore
  19. .bazelrc
  20. .bazelversion
  21. .clang-format
  22. .clang-format-ignore
  23. .clangd
  24. .gitattributes
  25. .gitignore
  26. API-CONVENTIONS.md
  27. AUTHORS
  28. BREAKING-CHANGES.md
  29. BUILD.bazel
  30. build.json
  31. BUILDING.md
  32. CMakeLists.txt
  33. codereview.settings
  34. CONTRIBUTING.md
  35. FUZZING.md
  36. go.mod
  37. go.sum
  38. INCORPORATING.md
  39. LICENSE
  40. MODULE.bazel
  41. MODULE.bazel.lock
  42. PORTING.md
  43. PRESUBMIT.py
  44. PrivacyInfo.xcprivacy
  45. README.md
  46. SANDBOXING.md
  47. SECURITY.md
  48. STYLE.md
README.md

BoringSSL

BoringSSL is a fork of OpenSSL that is designed to meet Google's needs.

Although BoringSSL is an open source project, it is not intended for general use, as OpenSSL is. We don't recommend that third parties depend upon it. Doing so is likely to be frustrating because there are no guarantees of API or ABI stability.

Programs ship their own copies of BoringSSL when they use it and we update everything as needed when deciding to make API changes. This allows us to mostly avoid compromises in the name of compatibility. It works for us, but it may not work for you.

BoringSSL arose because Google used OpenSSL for many years in various ways and, over time, built up a large number of patches that were maintained while tracking upstream OpenSSL. As Google's product portfolio became more complex, more copies of OpenSSL sprung up and the effort involved in maintaining all these patches in multiple places was growing steadily.

Currently BoringSSL is the SSL library in Chrome/Chromium, Android (but it's not part of the NDK) and a number of other apps/programs.

Project links:

To file a security issue, use the Chromium process and mention in the report this is for BoringSSL. You can ignore the parts of the process that are specific to Chromium/Chrome.

There are other files in this directory which might be helpful: