)]}'
{
  "commit": "03ca65809451c07c860b48b28bde043ec5197b26",
  "tree": "3d54d7de3144f47e29d82e3f6d80426049ea9c42",
  "parents": [
    "fe552c2c7e6341b0408f76afa9875f4850c90c3c"
  ],
  "author": {
    "name": "David Benjamin",
    "email": "davidben@google.com",
    "time": "Mon Nov 11 16:29:18 2024 -0500"
  },
  "committer": {
    "name": "Boringssl LUCI CQ",
    "email": "boringssl-scoped@luci-project-accounts.iam.gserviceaccount.com",
    "time": "Tue Nov 12 22:49:35 2024 +0000"
  },
  "message": "Reject NewSessionTicket messages with empty tickets in TLS 1.3\n\nIn TLS 1.2, the ticket field could be empty to indicate the server\nchanged its mind on sending a ticket, having previously committed to\nsending a NewSessionTicket message a round-trip ago.\n\nIn TLS 1.3, the server does not commit to sending NewSessionTicket. It\ncan always just not send it. So the ticket field is required to be\nnon-empty.\n\nIt\u0027s important we enforce this on the client because otherwise we\nproduce a mixed up SSL_SESSION object that looks like an ID session\n(thanks to the placeholder ID field that was added for a still unfixed\nEnvoy bug, see b/200292207). That, in turn, confuses some code in\nassembling the next ClientHello.\n\nThe subsequent CL will tighten that up.\n\nUpdate-Note: BoringSSL TLS 1.3 clients will now correctly reject\nzero-length tickets, rather than letting servers get us into a slightly\nfunny state.\n\nChange-Id: I1651e7887f9611ebc44ac54af89c85bf86a9feff\nReviewed-on: https://boringssl-review.googlesource.com/c/boringssl/+/73007\nCommit-Queue: David Benjamin \u003cdavidben@google.com\u003e\nAuto-Submit: David Benjamin \u003cdavidben@google.com\u003e\nReviewed-by: Adam Langley \u003cagl@google.com\u003e\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "7b08099e4fedd3a931944244be9c2d38c8bd4a98",
      "old_mode": 33188,
      "old_path": "ssl/test/runner/runner.go",
      "new_id": "4e90c3174b94b6f881dbea07c71fa9f5274734a8",
      "new_mode": 33188,
      "new_path": "ssl/test/runner/runner.go"
    },
    {
      "type": "modify",
      "old_id": "cac71b50d46cc7289d7a569d91073e0544f9e4c2",
      "old_mode": 33188,
      "old_path": "ssl/tls13_client.cc",
      "new_id": "a783a0a154e6c8676397cda6d8ed4d7343d7f19a",
      "new_mode": 33188,
      "new_path": "ssl/tls13_client.cc"
    }
  ]
}