commit 036152e6a550ccb929310b1f6f4c161fb80284fa
author David Benjamin <davidben@chromium.org> Fri Oct 23 18:14:14 2015 -0400
committer Adam Langley <alangley@gmail.com> Mon Oct 26 17:48:10 2015 +0000
tree 77c9a99054afc4bd25d17a5efd7fe9e1770f78aa
parent 0ea470fdb2d7e140351a3da800e80665a6013b91

Fix incorrect error-handling in BN_div_recp.

See upstream's e90f1d9b74275c11e3492e521e46f4b1afa6f883.

Change-Id: I68470acb97dac59e586b1c72aad50de6bd0156cb
Reviewed-on: https://boringssl-review.googlesource.com/6342
Reviewed-by: Adam Langley <alangley@gmail.com>

crypto/bn/exponentiation.c

diff --git a/crypto/bn/exponentiation.c b/crypto/bn/exponentiation.c
index ef18812..9cefa62 100644
--- a/crypto/bn/exponentiation.c
+++ b/crypto/bn/exponentiation.c
@@ -285,10 +285,10 @@
     goto err;
   }
 
-  if (BN_ucmp(m, &(recp->N)) < 0) {
+  if (BN_ucmp(m, &recp->N) < 0) {
     BN_zero(d);
     if (!BN_copy(r, m)) {
-      return 0;
+      goto err;
     }
     BN_CTX_end(ctx);
     return 1;