| commit | 0459431a2073a7220bb6fb9303d28680cc87aa68 | [log] [tgz] |
|---|---|---|
| author | Lily Chen <chlily@google.com> | Tue Sep 09 17:47:05 2025 -0400 |
| committer | Boringssl LUCI CQ <boringssl-scoped@luci-project-accounts.iam.gserviceaccount.com> | Tue Sep 09 15:06:43 2025 -0700 |
| tree | cf8c855d9f2b7f841f6a9afcf1b191a39e1c02cd | |
| parent | 94fddaedb3f0c8e0ef6bf3926e20be7bdba1925a [diff] |
Always populate supported_group_list SSL_CONFIG and SSL_CTX have a supported_group_list field which stores the ordered list of group IDs of groups supported for key exchange. These can be set by the caller via several setters (that either take group IDs, NIDs, or a string list), but there is a default list that is used if the caller hasn't configured the supported groups. Currently the default is evaluated by a getter, tls1_get_grouplist(), but it is more convenient if the supported_group_list field can be treated as a source of truth, i.e. if it contains the applicable groups at all times. This CL eliminates the getter, and instead populates supported_group_list with the default groups in SSL_CTX_new. The behavior of the various setters is preserved. The group ID and NID based setters now special-case an empty input to restore the default list. The string list based setter never accepted an empty string, so no changes are made to that. The public API documentation now mentions these behaviors explicitly. Update-Note: There should not be any behavior change. The documentation is updated to clarify what was existing behavior and is still the behavior of providing an empty list when setting supported groups. Change-Id: Iced20f80deb79fbd4b8bd560a00bf395e9b0e86b Reviewed-on: https://boringssl-review.googlesource.com/c/boringssl/+/81529 Reviewed-by: David Benjamin <davidben@google.com> Commit-Queue: Lily Chen <chlily@google.com>
BoringSSL is a fork of OpenSSL that is designed to meet Google's needs.
Although BoringSSL is an open source project, it is not intended for general use, as OpenSSL is. We don't recommend that third parties depend upon it. Doing so is likely to be frustrating because there are no guarantees of API or ABI stability.
Programs ship their own copies of BoringSSL when they use it and we update everything as needed when deciding to make API changes. This allows us to mostly avoid compromises in the name of compatibility. It works for us, but it may not work for you.
BoringSSL arose because Google used OpenSSL for many years in various ways and, over time, built up a large number of patches that were maintained while tracking upstream OpenSSL. As Google's product portfolio became more complex, more copies of OpenSSL sprung up and the effort involved in maintaining all these patches in multiple places was growing steadily.
Currently BoringSSL is the SSL library in Chrome/Chromium, Android (but it's not part of the NDK) and a number of other apps/programs.
Project links:
To file a security issue, use the Chromium process and mention in the report this is for BoringSSL. You can ignore the parts of the process that are specific to Chromium/Chrome.
There are other files in this directory which might be helpful: