Google Git
Sign in
boringssl / boringssl.git / f875db367c4da75676744cbaeb48a2d20940e510
commitf875db367c4da75676744cbaeb48a2d20940e510[log] [tgz]
authorDavid Benjamin <davidben@google.com>Thu Sep 18 17:10:44 2025 -0400
committerBoringssl LUCI CQ <boringssl-scoped@luci-project-accounts.iam.gserviceaccount.com>Sat Sep 20 16:23:04 2025 -0700
tree5e87c07b0b8650377be834b00d4d54d9a8520bea
parent05ff000a47f874a9856a6ca07af07fda4c056b48 [diff]
Reject explicit default X.509 versions and empty extension lists

X.509 version fields are declared as DEFAULT v1 which means, in DER, an
explicitly encoded version is invalid.

X.509 extension fields are declared as [3] EXPLICIT Extensions OPTIONAL
and Extensions ::= SEQUENCE SIZE (1..MAX) OF Extension.

This means in both BER and DER, the extensions list can never be empty.
Instead, a certificate or CRL with no extensions is supposed to be
encoded by omitting the OPTIONAL extensions field.

Also apply the version and extension checks to CRL entries, which we'd
missed earlier. All these checks are done by libpki.

Update-Note: X509 and X509_CRL parsers are now more spec-compliant and
reject some invalid inputs. After cl/809456844, internal tests have
passed with this change. The change was also validated with cl/800872048
and cl/802241042. Let us know if this encounters problems.

Fixed: 42290225, 442221114
Change-Id: I9a10d76ebb258f297079fc4d77b9eaf63f60b6c4
Reviewed-on: https://boringssl-review.googlesource.com/c/boringssl/+/82087
Reviewed-by: Adam Langley <agl@google.com>
Commit-Queue: David Benjamin <davidben@google.com>
Auto-Submit: David Benjamin <davidben@google.com>
3 files changed
tree: 5e87c07b0b8650377be834b00d4d54d9a8520bea
  1. .bcr/
  2. .github/
  3. cmake/
  4. crypto/
  5. decrepit/
  6. docs/
  7. fuzz/
  8. gen/
  9. include/
  10. infra/
  11. pki/
  12. rust/
  13. ssl/
  14. third_party/
  15. tool/
  16. util/
  17. .bazelignore
  18. .bazelrc
  19. .bazelversion
  20. .clang-format
  21. .gitignore
  22. API-CONVENTIONS.md
  23. AUTHORS
  24. BREAKING-CHANGES.md
  25. BUILD.bazel
  26. build.json
  27. BUILDING.md
  28. CMakeLists.txt
  29. codereview.settings
  30. CONTRIBUTING.md
  31. FUZZING.md
  32. go.mod
  33. go.sum
  34. INCORPORATING.md
  35. LICENSE
  36. MODULE.bazel
  37. MODULE.bazel.lock
  38. PORTING.md
  39. PrivacyInfo.xcprivacy
  40. README.md
  41. SANDBOXING.md
  42. STYLE.md
README.md

BoringSSL

BoringSSL is a fork of OpenSSL that is designed to meet Google's needs.

Although BoringSSL is an open source project, it is not intended for general use, as OpenSSL is. We don't recommend that third parties depend upon it. Doing so is likely to be frustrating because there are no guarantees of API or ABI stability.

Programs ship their own copies of BoringSSL when they use it and we update everything as needed when deciding to make API changes. This allows us to mostly avoid compromises in the name of compatibility. It works for us, but it may not work for you.

BoringSSL arose because Google used OpenSSL for many years in various ways and, over time, built up a large number of patches that were maintained while tracking upstream OpenSSL. As Google's product portfolio became more complex, more copies of OpenSSL sprung up and the effort involved in maintaining all these patches in multiple places was growing steadily.

Currently BoringSSL is the SSL library in Chrome/Chromium, Android (but it's not part of the NDK) and a number of other apps/programs.

Project links:

To file a security issue, use the Chromium process and mention in the report this is for BoringSSL. You can ignore the parts of the process that are specific to Chromium/Chrome.

There are other files in this directory which might be helpful: