Check extensions for X509_STORE certificates that aren't trust anchors

OpenSSL's path builder is odd. Typically one builds a path with:

- Target certificate
- Intermediates
- Trust anchor

But OpenSSL has:

- Target certificate
- "Untrusted" intermediates
- "Trusted" intermediates
- Trust anchor

"Trusted" intermediates come from the X509_STORE, but are not trust
anchors. They were functionally equivalent to "untrusted" intermediates,
in that you still have to chain up to a trust anchor. But some checks
apply differently (the last_untrusted field).  Historically, these
certificates didn't check critical extensions, key usage, etc.

As this is confusing and not a state supported by RFC 5280, stop
treating them funny. OpenSSL stopped doing this in 1.1.0 I believe. This
removes the need to track last_untrusted and removes the distinction
between "untrusted" and "trusted" intermediates.

Update-Note: Critical extensions, key usages, and path length
constraints will no longer be ignored for intermediate certificates
picked up from the X509_STORE. This is not expected to impact anyone,
and brings us closer to where upstream OpenSSL is now.

Fixed: 526486357
Change-Id: Ie597d79e9eb2f716f49b846a5cea806d92d89c43
Reviewed-on: https://boringssl-review.googlesource.com/c/boringssl/+/104308
Commit-Queue: David Benjamin <davidben@google.com>
Reviewed-by: Lily Chen <chlily@google.com>
3 files changed
tree: 4350b8eb0a4ee5a3e749c428c59a922c19cab9d8
  1. .agents/
  2. .bcr/
  3. .github/
  4. _agents/
  5. bench/
  6. cmake/
  7. crypto/
  8. decrepit/
  9. docs/
  10. fuzz/
  11. gen/
  12. include/
  13. infra/
  14. pki/
  15. rust/
  16. ssl/
  17. third_party/
  18. tool/
  19. util/
  20. .bazelignore
  21. .bazelrc
  22. .bazelversion
  23. .clang-format
  24. .clang-format-ignore
  25. .clangd
  26. .gitattributes
  27. .gitignore
  28. API-CONVENTIONS.md
  29. AUTHORS
  30. BREAKING-CHANGES.md
  31. BUILD.bazel
  32. build.json
  33. BUILDING.md
  34. CMakeLists.txt
  35. codereview.settings
  36. CONTRIBUTING.md
  37. FUZZING.md
  38. go.mod
  39. go.sum
  40. INCORPORATING.md
  41. LICENSE
  42. MODULE.bazel
  43. MODULE.bazel.lock
  44. PORTING.md
  45. PRESUBMIT.py
  46. PrivacyInfo.xcprivacy
  47. README.md
  48. SANDBOXING.md
  49. SECURITY.md
  50. STYLE.md
README.md

BoringSSL

BoringSSL is a fork of OpenSSL that is designed to meet Google's needs.

Although BoringSSL is an open source project, it is not intended for general use, as OpenSSL is. We don't recommend that third parties depend upon it. Doing so is likely to be frustrating because there are no guarantees of API or ABI stability.

Programs ship their own copies of BoringSSL when they use it and we update everything as needed when deciding to make API changes. This allows us to mostly avoid compromises in the name of compatibility. It works for us, but it may not work for you.

BoringSSL arose because Google used OpenSSL for many years in various ways and, over time, built up a large number of patches that were maintained while tracking upstream OpenSSL. As Google's product portfolio became more complex, more copies of OpenSSL sprung up and the effort involved in maintaining all these patches in multiple places was growing steadily.

Currently BoringSSL is the SSL library in Chrome/Chromium, Android (but it's not part of the NDK) and a number of other apps/programs.

Project links:

To file a security issue, use the Chromium process and mention in the report this is for BoringSSL. You can ignore the parts of the process that are specific to Chromium/Chrome.

There are other files in this directory which might be helpful: