)]}'
{
  "commit": "fcec1397a411cbe4e27bd1428dad63adf207dc33",
  "tree": "c057a9b7f941cf5bc2d6e2f8c0073c0cf5d5acc1",
  "parents": [
    "547221f5dc50e62543733cd65bd71bd97785afb6"
  ],
  "author": {
    "name": "David Benjamin",
    "email": "davidben@google.com",
    "time": "Tue Dec 12 13:58:22 2023 -0500"
  },
  "committer": {
    "name": "Boringssl LUCI CQ",
    "email": "boringssl-scoped@luci-project-accounts.iam.gserviceaccount.com",
    "time": "Tue Dec 12 20:57:47 2023 +0000"
  },
  "message": "Disable 32-bit Arm assembly optimizations on iOS\n\nThe last iOS version that supported 32-bit was iOS 10, which I don\u0027t\nbelieve any of our consumers support anymore. (Chromium does not,\nneither does google/oss-policies-info.) Our iOS CI coverage comes from\nChromium, so this means we don\u0027t actually have any test coverage for\n32-bit iOS, only compile coverage.\n\nIn addition to lacking any test coverage, 32-bit Arm assembly is more\nplatform-dependent than one might expect, between different limitiations\non patterns for PC-relative loads and lots of assembler quirks around\nwhat kinds of label expressions (which show up in PC-relative loads a\nlot) are allowed.\n\nFinally, since iOS in that era did not do runtime detection of features\nand relied on compiling a binary multiple times, the 32-bit assembly\nwould never enable AES acceleration anyway, so it\u0027s not as impactful as\non other platforms.\n\nBetween all that, it\u0027s no longer worth enabling this. Disable it in\ntarget.h which, with the all the recent build simplifications, should be\nsufficient to disable this code.\n\nUpdate-Note: iOS on 32-bit Arm now disables assembly. This is unlikely\nto impact anyone. As far as I can tell, 32-bit Arm for iOS thoroughly\ndoes not exist anymore.\n\nChange-Id: If31208b42047377ad1b4fb0af6fee17334f18330\nReviewed-on: https://boringssl-review.googlesource.com/c/boringssl/+/64748\nAuto-Submit: David Benjamin \u003cdavidben@google.com\u003e\nReviewed-by: Bob Beck \u003cbbe@google.com\u003e\nCommit-Queue: Bob Beck \u003cbbe@google.com\u003e\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "3e777313c30f0b4f97272ad74443d1c64e1164ed",
      "old_mode": 33188,
      "old_path": "include/openssl/target.h",
      "new_id": "d5b5c7e592d7bc696e57106bea27ee88e5f643da",
      "new_mode": 33188,
      "new_path": "include/openssl/target.h"
    }
  ]
}