| commit | 2fe0360a4e1b988e7b0aa0b4348bf55805512c09 | [log] [tgz] |
|---|---|---|
| author | David Benjamin <davidben@google.com> | Sat Jan 12 18:43:18 2019 +0000 |
| committer | CQ bot account: commit-bot@chromium.org <commit-bot@chromium.org> | Tue Jan 22 23:18:36 2019 +0000 |
| tree | 4d41735dbd152eb5ed9958cb56183caf7374a55d | |
| parent | 72f015562c145a15e12af5ec588c7596a5de120c [diff] |
Fix undefined pointer casts in SHA-512 code. Casting an unaligned pointer to uint64_t* is undefined, even on platforms that support unaligned access. Additionally, dereferencing as uint64_t violates strict aliasing rules. Instead, use memcpys which we assume any sensible compiler can optimize. Also simplify the PULL64 business with the existing CRYPTO_bswap8. This also removes the need for the SHA512_BLOCK_CAN_MANAGE_UNALIGNED_DATA logic. The generic C code now handles unaligned data and the assembly already can as well. (The only problematic platform with assembly is old ARM, but sha512-armv4.pl already handles this via an __ARM_ARCH__ check. See also OpenSSL's version of this file which always defines SHA512_BLOCK_CAN_MANAGE_UNALIGNED_DATA if SHA512_ASM is defined.) Add unaligned tests to digest_test.cc, so we retain coverage of unaligned EVP_MD inputs. Change-Id: Idfd8586c64bab2a77292af2fa8eebbd193e57c7d Reviewed-on: https://boringssl-review.googlesource.com/c/34444 Commit-Queue: Adam Langley <agl@google.com> Reviewed-by: Adam Langley <agl@google.com>
BoringSSL is a fork of OpenSSL that is designed to meet Google's needs.
Although BoringSSL is an open source project, it is not intended for general use, as OpenSSL is. We don't recommend that third parties depend upon it. Doing so is likely to be frustrating because there are no guarantees of API or ABI stability.
Programs ship their own copies of BoringSSL when they use it and we update everything as needed when deciding to make API changes. This allows us to mostly avoid compromises in the name of compatibility. It works for us, but it may not work for you.
BoringSSL arose because Google used OpenSSL for many years in various ways and, over time, built up a large number of patches that were maintained while tracking upstream OpenSSL. As Google's product portfolio became more complex, more copies of OpenSSL sprung up and the effort involved in maintaining all these patches in multiple places was growing steadily.
Currently BoringSSL is the SSL library in Chrome/Chromium, Android (but it's not part of the NDK) and a number of other apps/programs.
There are other files in this directory which might be helpful: