| commit | fae0964b3d44e94ca2a2d21f86e61dabe683d130 | [log] [tgz] |
|---|---|---|
| author | Bob Beck <bbe@google.com> | Tue Mar 12 19:31:09 2024 +0000 |
| committer | Boringssl LUCI CQ <boringssl-scoped@luci-project-accounts.iam.gserviceaccount.com> | Wed Mar 13 15:52:19 2024 +0000 |
| tree | 32afb7984ef813e6381f34f1f7bb46f45d3a0780 | |
| parent | 356d37861f5772e2d87ef443f61f33c020e52b04 [diff] |
Re-remove unnecesary stat calls from by_dir.c After examining consumer test code and discussion with davidben, the stat here serves only to get out of this code without having an error on the error stack when the file does not exist, which is then interpreted as the CA or CRL does not exist. Instead, we simply attempt to open the files, and if it does not work for any reason, clear the error that was set. This changes us to treat any failure in finding a CA or CRL using the by directory lookup as if the file was just not present. This ensures a consistent behaviour with the error returned from the verification code. We don't differentiate between the file not existing or other errors such as garbage in the file. Fixed: 708 Change-Id: I1eee01282cde803fb7c9b52003da3dfbd5ba9e33 Reviewed-on: https://boringssl-review.googlesource.com/c/boringssl/+/66967 Reviewed-by: David Benjamin <davidben@google.com> Commit-Queue: David Benjamin <davidben@google.com>
BoringSSL is a fork of OpenSSL that is designed to meet Google's needs.
Although BoringSSL is an open source project, it is not intended for general use, as OpenSSL is. We don't recommend that third parties depend upon it. Doing so is likely to be frustrating because there are no guarantees of API or ABI stability.
Programs ship their own copies of BoringSSL when they use it and we update everything as needed when deciding to make API changes. This allows us to mostly avoid compromises in the name of compatibility. It works for us, but it may not work for you.
BoringSSL arose because Google used OpenSSL for many years in various ways and, over time, built up a large number of patches that were maintained while tracking upstream OpenSSL. As Google's product portfolio became more complex, more copies of OpenSSL sprung up and the effort involved in maintaining all these patches in multiple places was growing steadily.
Currently BoringSSL is the SSL library in Chrome/Chromium, Android (but it's not part of the NDK) and a number of other apps/programs.
Project links:
There are other files in this directory which might be helpful: