commit | f99f2448bd06ffa96575397d37a5caaebf3018d4 | [log] [tgz] |
---|---|---|
author | Adam Langley <alangley@gmail.com> | Sun Oct 02 09:53:38 2016 -0700 |
committer | CQ bot account: commit-bot@chromium.org <commit-bot@chromium.org> | Mon Oct 03 18:03:08 2016 +0000 |
tree | 16afa1d5ed2335a69536d2baf98655f681a9ba39 | |
parent | 0aecbcf62ed2fc8ddbb7fd7ee36d284a2c4a5c70 [diff] |
Return immediately if a cipher command is invalid. Breaking from inside the inner loop doesn't do what the code wants. Instead the outer loop will continue running and it's possible for it to read off the end of the buffer. (Found with libFuzzer.) Next change will update the other abort points in this code to match. Change-Id: I006dca0cd4c31db1c4b5e84b996fe24b2f1e6c13 Reviewed-on: https://boringssl-review.googlesource.com/11421 Reviewed-by: David Benjamin <davidben@google.com> Commit-Queue: David Benjamin <davidben@google.com> CQ-Verified: CQ bot account: commit-bot@chromium.org <commit-bot@chromium.org>
BoringSSL is a fork of OpenSSL that is designed to meet Google's needs.
Although BoringSSL is an open source project, it is not intended for general use, as OpenSSL is. We don't recommend that third parties depend upon it. Doing so is likely to be frustrating because there are no guarantees of API or ABI stability.
Programs ship their own copies of BoringSSL when they use it and we update everything as needed when deciding to make API changes. This allows us to mostly avoid compromises in the name of compatibility. It works for us, but it may not work for you.
BoringSSL arose because Google used OpenSSL for many years in various ways and, over time, built up a large number of patches that were maintained while tracking upstream OpenSSL. As Google's product portfolio became more complex, more copies of OpenSSL sprung up and the effort involved in maintaining all these patches in multiple places was growing steadily.
Currently BoringSSL is the SSL library in Chrome/Chromium, Android (but it's not part of the NDK) and a number of other apps/programs.
There are other files in this directory which might be helpful: