Reland "crypto/x509: Verify standalone Merkle Tree Certs (MTCs)" This reverts commit 96a007fb323e49e5637e018f7f4927addd851d6f, thus relanding commit f89068d3030374395c4b070838d1f4d9bbef5465. The build failure in Chromium's component build was because accessing impl->tbs_sig_alg.get() instantiates the StackAllocated<X509_ALGOR, ...> template, which emits relocations for internal symbols (x509_algor_init and x509_algor_cleanup), and these are not pruned in unoptimized mode. The fix (diff from patchset 1) is to avoid reaching into X509Impl internals to construct the test cert. Instead, all the desired (intentionally invalid) test certs were generated by the MTC demo tool, and checked in as testdata and parsed directly. Original change's description: > Revert "crypto/x509: Verify standalone Merkle Tree Certs (MTCs)" > > This reverts commit f89068d3030374395c4b070838d1f4d9bbef5465. > > Reason for revert: build failure crbug.com/549361069 > > Failure Link: https://ci.chromium.org/ui/p/chrome/builders/try/linux-chrome-dbg-cog-cache-warmer/79105/overview > > Original change's description: > > crypto/x509: Verify standalone Merkle Tree Certs (MTCs) > > > > This implements verification of "standalone" Merkle Tree Certs (see > > draft-ietf-plants-merkle-tree-certs-05, section 6.3) as part of the > > X509_STORE_CTX API, if the flag X509_V_FLAG_USE_MTC_DRAFT_PLANTS_05 > > is specified. > > > > Bug: 503746594 > > Change-Id: Ie5abd17eb34c37139d3be1261e1914976a6a6964 > > Reviewed-on: https://boringssl-review.googlesource.com/c/boringssl/+/100707 > > Reviewed-by: David Benjamin <davidben@google.com> > > Commit-Queue: Lily Chen <chlily@google.com> > > Presubmit-BoringSSL-Verified: boringssl-scoped@luci-project-accounts.iam.gserviceaccount.com <boringssl-scoped@luci-project-accounts.iam.gserviceaccount.com> > > TBR=davidben@google.com,boringssl-scoped@luci-project-accounts.iam.gserviceaccount.com,chlily@google.com > > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 503746594, 549361069 > Change-Id: If43293ba7c2199a463a98dcf848fcc60bdd1e9bb > Reviewed-on: https://boringssl-review.googlesource.com/c/boringssl/+/101307 > Presubmit-BoringSSL-Verified: boringssl-scoped@luci-project-accounts.iam.gserviceaccount.com <boringssl-scoped@luci-project-accounts.iam.gserviceaccount.com> > Auto-Submit: Lily Chen <chlily@google.com> > Reviewed-by: David Benjamin <davidben@google.com> > Commit-Queue: David Benjamin <davidben@google.com> # Not skipping CQ checks because this is a reland. Bug: 503746594 Cq-Include-Trybots: luci.boringssl.try:linux_clang_shared_compile,linux_clang_shared_rel_compile Change-Id: I2376b492ecc0e6bfcfc0acb36cc0f1511dd29db7 Reviewed-on: https://boringssl-review.googlesource.com/c/boringssl/+/101467 Commit-Queue: Lily Chen <chlily@google.com> Reviewed-by: David Benjamin <davidben@google.com>
BoringSSL is a fork of OpenSSL that is designed to meet Google's needs.
Although BoringSSL is an open source project, it is not intended for general use, as OpenSSL is. We don't recommend that third parties depend upon it. Doing so is likely to be frustrating because there are no guarantees of API or ABI stability.
Programs ship their own copies of BoringSSL when they use it and we update everything as needed when deciding to make API changes. This allows us to mostly avoid compromises in the name of compatibility. It works for us, but it may not work for you.
BoringSSL arose because Google used OpenSSL for many years in various ways and, over time, built up a large number of patches that were maintained while tracking upstream OpenSSL. As Google's product portfolio became more complex, more copies of OpenSSL sprung up and the effort involved in maintaining all these patches in multiple places was growing steadily.
Currently BoringSSL is the SSL library in Chrome/Chromium, Android (but it's not part of the NDK) and a number of other apps/programs.
Project links:
To file a security issue, use the Chromium process and mention in the report this is for BoringSSL. You can ignore the parts of the process that are specific to Chromium/Chrome.
There are other files in this directory which might be helpful: