commit f04c2e987871f852d0ec391005d9202157999523
author David Benjamin <davidben@google.com> Tue Dec 06 13:35:25 2016 -0500
committer Adam Langley <agl@google.com> Thu Dec 08 16:39:52 2016 +0000
tree 3661c096b6be8fdddab4147a30c76fbae432aa2d
parent a2bda9fb95a9e9945d6ee12847c9b6022e8cd8af

Move client_version into SSL_HANDSHAKE.

There is no need to retain it beyond this point.

Change-Id: Ib5722ab30fc013380198b1582d1240f0fe0aa770
Reviewed-on: https://boringssl-review.googlesource.com/12620
Reviewed-by: Adam Langley <agl@google.com>

ssl/t1_lib.c

diff --git a/ssl/t1_lib.c b/ssl/t1_lib.c
index fa1c067..474f50a 100644
--- a/ssl/t1_lib.c
+++ b/ssl/t1_lib.c
@@ -2733,8 +2733,8 @@
 
 int ssl_add_clienthello_tlsext(SSL_HANDSHAKE *hs, CBB *out, size_t header_len) {
   SSL *const ssl = hs->ssl;
-  /* don't add extensions for SSLv3 unless doing secure renegotiation */
-  if (ssl->client_version == SSL3_VERSION &&
+  /* Don't add extensions for SSLv3 unless doing secure renegotiation. */
+  if (hs->client_version == SSL3_VERSION &&
       !ssl->s3->send_connection_binding) {
     return 1;
   }