commit | 63a0797ff247f13870b649c3f6239d80be202752 | [log] [tgz] |
---|---|---|
author | David Benjamin <davidben@google.com> | Mon Oct 02 13:32:09 2017 -0400 |
committer | Adam Langley <agl@google.com> | Mon Oct 02 20:02:22 2017 +0000 |
tree | 286ed8ee6b346b23de4ddeae2789010155f79b1f | |
parent | b949355132778aa1e56fd58cd5e5180a014b4e58 [diff] |
Remove now unnecessary _POSIX_C_SOURCE bits to work around macOS bug. crypto/bio/bio_test.cc - I'm not sure where this was added for, but none of the functions used there appear to have feature macros documented. crypto/bio/printf.c - -std=c99 provides (v)snprintf. crypto/lhash/lhash_test.cc - we no longer call rand_r. crypto/mem.c - we no longer call strdup and -std=c99 provides (v)snprintf. Apple messed up their headers and, if _POSIX_C_SOURCE is defined but _DARWIN_C_SOURCE isn't, pthread.h no longer defines mach_port_t. They then shipped a version of libc++ headers that is missing this fix, so the build breaks: https://github.com/llvm-mirror/libcxx/commit/bcc92d75df0274b9593ebd097fcae60494e3bffc If one uses XCode, they've hacked their pthread.h to provide mach_port_t if defined(__cplusplus), but the standalone tools appear to be old and missing this. We can work around this by also defining _DARWIN_C_SOURCE in C++ files that need _POSIX_C_SOURCE, but it appears none of these files actually need it. Change-Id: I5df9453730696100eb22b809febeb65053701322 Reviewed-on: https://boringssl-review.googlesource.com/20964 Reviewed-by: Adam Langley <agl@google.com>
BoringSSL is a fork of OpenSSL that is designed to meet Google's needs.
Although BoringSSL is an open source project, it is not intended for general use, as OpenSSL is. We don't recommend that third parties depend upon it. Doing so is likely to be frustrating because there are no guarantees of API or ABI stability.
Programs ship their own copies of BoringSSL when they use it and we update everything as needed when deciding to make API changes. This allows us to mostly avoid compromises in the name of compatibility. It works for us, but it may not work for you.
BoringSSL arose because Google used OpenSSL for many years in various ways and, over time, built up a large number of patches that were maintained while tracking upstream OpenSSL. As Google's product portfolio became more complex, more copies of OpenSSL sprung up and the effort involved in maintaining all these patches in multiple places was growing steadily.
Currently BoringSSL is the SSL library in Chrome/Chromium, Android (but it's not part of the NDK) and a number of other apps/programs.
There are other files in this directory which might be helpful: