Fix (harmless) memory leak in the test harness.
Change-Id: Ia0daaaaf464cfa0e9d563d7f376ce2bb2e338685
Reviewed-on: https://boringssl-review.googlesource.com/1560
Reviewed-by: David Benjamin <davidben@chromium.org>
Reviewed-by: Adam Langley <agl@google.com>
diff --git a/ssl/test/bssl_shim.cc b/ssl/test/bssl_shim.cc
index bc4a186..c976e7c 100644
--- a/ssl/test/bssl_shim.cc
+++ b/ssl/test/bssl_shim.cc
@@ -482,27 +482,30 @@
return 1;
}
- SSL_SESSION *session;
+ SSL_SESSION *session = NULL;
int ret = do_exchange(&session,
ssl_ctx, &config,
false /* is_resume */,
3 /* fd */, NULL /* session */);
if (ret != 0) {
- return ret;
+ goto out;
}
if (config.resume) {
- int ret = do_exchange(NULL,
- ssl_ctx, &config,
- true /* is_resume */,
- 4 /* fd */,
- config.is_server ? NULL : session);
+ ret = do_exchange(NULL,
+ ssl_ctx, &config,
+ true /* is_resume */,
+ 4 /* fd */,
+ config.is_server ? NULL : session);
if (ret != 0) {
- return ret;
+ goto out;
}
}
+ ret = 0;
+
+out:
SSL_SESSION_free(session);
SSL_CTX_free(ssl_ctx);
- return 0;
+ return ret;
}
