| commit | d1e28ad53bec8e1ad6f642792ab663e7e509f67b | [log] [tgz] |
|---|---|---|
| author | David Benjamin <davidben@google.com> | Thu Jun 30 13:50:32 2016 -0400 |
| committer | Adam Langley <agl@google.com> | Thu Jun 30 22:27:48 2016 +0000 |
| tree | 74bffd4e74ebad1314e5aa5ce8715a03f5984377 | |
| parent | 929d4ee84974ed12dfe16bb7138443eba16c3321 [diff] |
Remove key_exchange_info for plain RSA. This isn't filled in on the client and Chromium no longer uses it for plain RSA. It's redundant with existing APIs. This is part of removing the need for callers to call SSL_get_session where possible. SSL_get_session is ambiguous when it comes to renego. Some code wants the current connection state which should not include the pending handshake and some code wants the handshake scratch space which should. Renego doesn't exist in TLS 1.3, but TLS 1.3 makes NewSessionTicket a post-handshake message, so SSL_get_session is somewhat silly of an API there too. SSL_SESSION_get_key_exchange_info is a BoringSSL-only API, so we can freely change it and replace it with APIs keyed on SSL. In doing so, I think it is better to provide APIs like "SSL_get_dhe_group_size" and "SSL_get_curve_id" rather than make the caller do the multi-step SSL_get_current_cipher / SSL_CIPHER_is_ECDHE dance. To that end, RSA key_exchange_info is pointless as it can already be determined from the peer certificate. Change-Id: Ie90523083d8649701c17934b7be0383502a0caa3 Reviewed-on: https://boringssl-review.googlesource.com/8564 Reviewed-by: Adam Langley <agl@google.com>
BoringSSL is a fork of OpenSSL that is designed to meet Google's needs.
Although BoringSSL is an open source project, it is not intended for general use, as OpenSSL is. We don't recommend that third parties depend upon it. Doing so is likely to be frustrating because there are no guarantees of API or ABI stability.
Programs ship their own copies of BoringSSL when they use it and we update everything as needed when deciding to make API changes. This allows us to mostly avoid compromises in the name of compatibility. It works for us, but it may not work for you.
BoringSSL arose because Google used OpenSSL for many years in various ways and, over time, built up a large number of patches that were maintained while tracking upstream OpenSSL. As Google's product portfolio became more complex, more copies of OpenSSL sprung up and the effort involved in maintaining all these patches in multiple places was growing steadily.
Currently BoringSSL is the SSL library in Chrome/Chromium, Android (but it's not part of the NDK) and a number of other apps/programs.
There are other files in this directory which might be helpful: