)]}'
{
  "commit": "cd24a39f1b3644da333bfcb43865ab7a6587c5cc",
  "tree": "d2d84607437b31221c5e0ed6141ae93a7fd41088",
  "parents": [
    "99fdfb9f22208c1152c381be3087cd9380a58d66"
  ],
  "author": {
    "name": "David Benjamin",
    "email": "davidben@chromium.org",
    "time": "Wed Nov 11 13:23:05 2015 -0800"
  },
  "committer": {
    "name": "Adam Langley",
    "email": "agl@google.com",
    "time": "Wed Nov 11 22:18:39 2015 +0000"
  },
  "message": "Limit DHE groups to 4096-bit.\n\ndh.c had a 10k-bit limit but it wasn\u0027t quite correctly enforced. However,\nthat\u0027s still 1.12s of jank on the IO thread, which is too long. Since the SSL\ncode consumes DHE groups from the network, it should be responsible for\nenforcing what sanity it needs on them.\n\nCosts of various bit lengths on 2013 Macbook Air:\n1024 - 1.4ms\n2048 - 14ms\n3072 - 24ms\n4096 - 55ms\n5000 - 160ms\n10000 - 1.12s\n\nUMA says that DHE groups are 0.2% 4096-bit and otherwise are 5.5% 2048-bit and\n94% 1024-bit and some noise. Set the limit to 4096-bit to be conservative,\nalthough that\u0027s already quite a lot of jank.\n\nBUG\u003d554295\n\nChange-Id: I8e167748a67e4e1adfb62d73dfff094abfa7d215\nReviewed-on: https://boringssl-review.googlesource.com/6464\nReviewed-by: Adam Langley \u003cagl@google.com\u003e\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "a88520d237bc5b9039eeda5adeb1b846efce4b08",
      "old_mode": 33188,
      "old_path": "crypto/dh/dh.c",
      "new_id": "5409a653bac76763932d1c83517d361dae8e2ecc",
      "new_mode": 33188,
      "new_path": "crypto/dh/dh.c"
    },
    {
      "type": "modify",
      "old_id": "0b30b13edddae263159c6d778e8fcc5e98ad4a83",
      "old_mode": 33188,
      "old_path": "crypto/err/ssl.errordata",
      "new_id": "41a657f586210d7a4a7b67839eaef8e175f9e71c",
      "new_mode": 33188,
      "new_path": "crypto/err/ssl.errordata"
    },
    {
      "type": "modify",
      "old_id": "38d838d3ef9ece6ab740f7d509302f97ffbb2dfa",
      "old_mode": 33188,
      "old_path": "include/openssl/ssl.h",
      "new_id": "29adcb35b040276241ac1f6850a7cb0302eada74",
      "new_mode": 33188,
      "new_path": "include/openssl/ssl.h"
    },
    {
      "type": "modify",
      "old_id": "b474352d3e9f7b9d6788a9f1856e31b6eee2ea21",
      "old_mode": 33188,
      "old_path": "ssl/s3_clnt.c",
      "new_id": "eb96780bb56071a6813f51164c4db7f9c98c64d9",
      "new_mode": 33188,
      "new_path": "ssl/s3_clnt.c"
    },
    {
      "type": "modify",
      "old_id": "6573871568a512ab864c5a1c68c3ffe419b128cf",
      "old_mode": 33188,
      "old_path": "ssl/test/runner/runner.go",
      "new_id": "a1801c8ebf06cff470101d58c1577632b44ea8cf",
      "new_mode": 33188,
      "new_path": "ssl/test/runner/runner.go"
    }
  ]
}
