)]}'
{
  "commit": "c47bfce062cc5a1b462176be626338224ae2a346",
  "tree": "b10b17036aacc666fbe41061f063521df1798ac8",
  "parents": [
    "2d691ca60ddb535a7a54fb07fd2252bd6017bee7"
  ],
  "author": {
    "name": "David Benjamin",
    "email": "davidben@google.com",
    "time": "Wed Jan 20 17:10:32 2021 -0500"
  },
  "committer": {
    "name": "CQ bot account: commit-bot@chromium.org",
    "email": "commit-bot@chromium.org",
    "time": "Wed Jan 20 22:57:32 2021 +0000"
  },
  "message": "Define TLSEXT_TYPE_quic_transport_parameters to the old code point for now.\n\nQUICHE currently does not know to call\nSSL_set_quic_use_legacy_codepoint, picking up the current default of the\nlegacy code point. It then assumes that the\nTLSEXT_TYPE_quic_transport_parameters constant may be used to extract\ntransport parameters, so after\nhttps://boringssl-review.googlesource.com/c/boringssl/+/44704, it\nbreaks.\n\nTo smooth over the transition, we now define three constants:\nTLSEXT_TYPE_quic_transport_parameters_legacy,\nTLSEXT_TYPE_quic_transport_parameters_standard, and the old constant.\nThe old constant will match whatever the default is (for now, legacy) so\nthe default is self-consistent. Then plan is then:\n\n1. BoringSSL switches to the state in this CL: the default code point\n   and constant are the legacy one, but there are APIs to specify the\n   code point. This will not affect QUICHE, which only uses the\n   defaults.\n\n2. QUICHE calls SSL_set_quic_use_legacy_codepoint and uses the\n   corresponding _legacy or _standard constant. It should *not* use the\n   unsuffixed constant at this point.\n\n3. BoringSSL switches the default setting and the constant to the\n   standard code point. This will not affect QUICHE, which explicitly\n   configures the code point it wants.\n\n4. Optional: BoringSSL won\u0027t switch the default back to legacy, so\n   QUICHE can switch _standard to unsuffixed and BoringSSL\n   can remove the _standard alias (but not the function) early.\n\n5. When QUICHE no longer needs both code points, it unwinds the\n   SSL_set_quic_use_legacy_codepoint code and switches back to the\n   unsuffixed constant.\n\n6. BoringSSL removes all this scaffolding now that it\u0027s no longer\n   needed.\n\nUpdate-Note: This this fixes a compatibility issue with\nhttps://boringssl-review.googlesource.com/c/boringssl/+/44704.\n\nChange-Id: I9f75845aba58ba93e9665cd6f05bcd080eb5f139\nReviewed-on: https://boringssl-review.googlesource.com/c/boringssl/+/45124\nReviewed-by: David Schinazi \u003cdschinazi@google.com\u003e\nReviewed-by: David Benjamin \u003cdavidben@google.com\u003e\nCommit-Queue: David Benjamin \u003cdavidben@google.com\u003e\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "0fbea9ea6ccfafaee4445c21624f72e775d5680c",
      "old_mode": 33188,
      "old_path": "include/openssl/tls1.h",
      "new_id": "da79a08a94412ed7fc2cd26cc8a6cad787008d0d",
      "new_mode": 33188,
      "new_path": "include/openssl/tls1.h"
    },
    {
      "type": "modify",
      "old_id": "d1d525cc7ed3b64aa5ce4563339434073ba8ceaa",
      "old_mode": 33188,
      "old_path": "ssl/ssl_test.cc",
      "new_id": "637f4d5c6e0f2e3153707ed10ca644618767cd9f",
      "new_mode": 33188,
      "new_path": "ssl/ssl_test.cc"
    },
    {
      "type": "modify",
      "old_id": "5ca9610999d310ba72d01d7e1304085c81a5221d",
      "old_mode": 33188,
      "old_path": "ssl/t1_lib.cc",
      "new_id": "342c17021f40ec351746d240453e86c0e39f65fd",
      "new_mode": 33188,
      "new_path": "ssl/t1_lib.cc"
    }
  ]
}