)]}'
{
  "commit": "bd1fa86feb7de41910ed111d003fd1b49235168a",
  "tree": "10e53ac1aeb68c44ce34468f510f920bb28d4e2c",
  "parents": [
    "243a29241ca582a6e47bb5caa193be12cf8890f9"
  ],
  "author": {
    "name": "David Benjamin",
    "email": "davidben@google.com",
    "time": "Mon Apr 06 14:34:09 2020 -0400"
  },
  "committer": {
    "name": "Adam Langley",
    "email": "agl@google.com",
    "time": "Tue Apr 07 20:28:59 2020 +0000"
  },
  "message": "Clean up various EC inversion functions.\n\nThis fixes two issues. First, we have been lax about whether the\nlow-level inversion functions fail on zero input or output zero. Fix the\ndocumentation and call the latter inv0 or inverse0 to match the\nterminology used in draft-irtf-cfrg-hash-to-curve. (Although we may not\nactually need inv0 given the optimization in D.2.)\n\nThis has no actual effect because the functions were only used in\ncontexts where the inputs were already guaranteed to be non-zero. Still,\nwe should be consistent here.\n\nSecond, ec_scalar_inv_montgomery and ec_scalar_inv_montgomery_vartime\nclaim to perform the same operation, but they do not. First, one\ncomputed inv0 and the other computed inv (except only in some\nimplementations, so fix it to be consistent). Second, the former\ncomputes inverses in the Montgomery domain, while the latter converts to\nthe Montgomery domain and then inverts. Rename it to\nec_scalar_to_montgomery_inv_vartime, which is... questionably\nunderstandable but at least looks different.\n\nChange-Id: I9b4829ce5013bdb9528078a093f41b1b158df265\nReviewed-on: https://boringssl-review.googlesource.com/c/boringssl/+/40526\nReviewed-by: Adam Langley \u003cagl@google.com\u003e\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "8d4a5c8b346055aec43fd8ccdc523bc82aea4bdf",
      "old_mode": 33188,
      "old_path": "crypto/fipsmodule/bn/exponentiation.c",
      "new_id": "f2c3f68142df1198cc62a5bf512ae46915316844",
      "new_mode": 33188,
      "new_path": "crypto/fipsmodule/bn/exponentiation.c"
    },
    {
      "type": "modify",
      "old_id": "d58a2acce79865b9f703c052c00cb6590a91925f",
      "old_mode": 33188,
      "old_path": "crypto/fipsmodule/bn/internal.h",
      "new_id": "f27f3e7f4801e98fd4fa5f0dc652bae5d0a15b49",
      "new_mode": 33188,
      "new_path": "crypto/fipsmodule/bn/internal.h"
    },
    {
      "type": "modify",
      "old_id": "0cf1d910d15d06290d19576330368d7074ee8b42",
      "old_mode": 33188,
      "old_path": "crypto/fipsmodule/ec/ec_montgomery.c",
      "new_id": "5553f0528864d5c44b180676761ffe3a5bfa3e8b",
      "new_mode": 33188,
      "new_path": "crypto/fipsmodule/ec/ec_montgomery.c"
    },
    {
      "type": "modify",
      "old_id": "4f05d1f24ac64e7f8d5bb130347734fcad445ce3",
      "old_mode": 33188,
      "old_path": "crypto/fipsmodule/ec/internal.h",
      "new_id": "d076c91b6c39c0d98e1b53ad5f1554b75f02c6f6",
      "new_mode": 33188,
      "new_path": "crypto/fipsmodule/ec/internal.h"
    },
    {
      "type": "modify",
      "old_id": "f8af39bef8f23f6e9d105a8ecc564cccb3df27eb",
      "old_mode": 33188,
      "old_path": "crypto/fipsmodule/ec/p224-64.c",
      "new_id": "fa7ede1dbaaed6c79d5a0e39c2c899bb9e126aad",
      "new_mode": 33188,
      "new_path": "crypto/fipsmodule/ec/p224-64.c"
    },
    {
      "type": "modify",
      "old_id": "b4af5446576e876c85da71a49a5d62411b4ae620",
      "old_mode": 33188,
      "old_path": "crypto/fipsmodule/ec/p256-x86_64.c",
      "new_id": "3993ff4cdc2054bd0c086bbd8504120832effe8b",
      "new_mode": 33188,
      "new_path": "crypto/fipsmodule/ec/p256-x86_64.c"
    },
    {
      "type": "modify",
      "old_id": "4b4f874b982b7e32895f4361093752ebd523b3f4",
      "old_mode": 33188,
      "old_path": "crypto/fipsmodule/ec/scalar.c",
      "new_id": "595d3ff7d3798af92702986e7ccb8456879d3be8",
      "new_mode": 33188,
      "new_path": "crypto/fipsmodule/ec/scalar.c"
    },
    {
      "type": "modify",
      "old_id": "c418c4e3e594f980e91016114f37780e434a55a5",
      "old_mode": 33188,
      "old_path": "crypto/fipsmodule/ec/simple.c",
      "new_id": "8536b808678afd78620c37ee231613a3d3dedf28",
      "new_mode": 33188,
      "new_path": "crypto/fipsmodule/ec/simple.c"
    },
    {
      "type": "modify",
      "old_id": "56d9f166fdd0c9579f8c8aa411aa4d0f7b5cbfaf",
      "old_mode": 33188,
      "old_path": "crypto/fipsmodule/ecdsa/ecdsa.c",
      "new_id": "096b6150265adfbe59cbad4da450ac8c26db2ad8",
      "new_mode": 33188,
      "new_path": "crypto/fipsmodule/ecdsa/ecdsa.c"
    },
    {
      "type": "modify",
      "old_id": "23ec71f98cd75184b113cbcd7aea0e2f7cd9ed9a",
      "old_mode": 33188,
      "old_path": "third_party/fiat/p256.c",
      "new_id": "dd113c4b813cdbac89e85648fa5f7ff87c14f12d",
      "new_mode": 33188,
      "new_path": "third_party/fiat/p256.c"
    }
  ]
}