commit b98ce18c5b3f0c28bd64b27b6494f176404da4e4
author David Benjamin <davidben@google.com> Tue Jul 11 20:08:42 2023 -0400
committer Boringssl LUCI CQ <boringssl-scoped@luci-project-accounts.iam.gserviceaccount.com> Wed Jul 12 01:04:17 2023 +0000
tree 775a6b6add4a5f797a4b584c3d735e05a5d72855
parent 690dcdf5c9792f7ab4ca6e3e009a6e0da9ebe933

Fix error condition in new iOS CRYPTO_sysrand

Possibly we should run this on macOS too, so we have better test
coverage.

Bug: 287
Change-Id: I3005a445f8cb7559e91317be91a42c1db15f081a
Reviewed-on: https://boringssl-review.googlesource.com/c/boringssl/+/61529
Commit-Queue: David Benjamin <davidben@google.com>
Reviewed-by: Adam Langley <agl@google.com>
Commit-Queue: Adam Langley <agl@google.com>
Auto-Submit: David Benjamin <davidben@google.com>

crypto/rand_extra/ios.c

diff --git a/crypto/rand_extra/ios.c b/crypto/rand_extra/ios.c
index c41d0d1..73f0ef3 100644
--- a/crypto/rand_extra/ios.c
+++ b/crypto/rand_extra/ios.c
@@ -22,7 +22,7 @@
 #include <CommonCrypto/CommonRandom.h>
 
 void CRYPTO_sysrand(uint8_t *out, size_t requested) {
-  if (CCRandomGenerateBytes(out, requested) == kCCSuccess) {
+  if (CCRandomGenerateBytes(out, requested) != kCCSuccess) {
     abort();
   }
 }