commit a7fbc543c9b2305befee733d689fdf8b821ab880
author David Benjamin <davidben@google.com> Sun Dec 11 11:57:04 2022 -0500
committer Boringssl LUCI CQ <boringssl-scoped@luci-project-accounts.iam.gserviceaccount.com> Mon Jan 30 22:08:43 2023 +0000
tree aba36074726d6ddc0c637384dc52b82dcecace9b
parent f86a63c87cee3935254b3f5298712ca6cff1a589

Remove now unnecessary check in CBS_peek_asn1_tag.

Since we started supporting higher tag numbers, this function needed to
call parse_asn1_tag, which is internally bounds-checked.

Change-Id: I19202fb1256240155fa1b53dd31f2b96fd0e8d40
Reviewed-on: https://boringssl-review.googlesource.com/c/boringssl/+/56188
Commit-Queue: Bob Beck <bbe@google.com>
Reviewed-by: Bob Beck <bbe@google.com>
Auto-Submit: David Benjamin <davidben@google.com>

crypto/bytestring/cbs.c

diff --git a/crypto/bytestring/cbs.c b/crypto/bytestring/cbs.c
index 30e38fa..8f81586 100644
--- a/crypto/bytestring/cbs.c
+++ b/crypto/bytestring/cbs.c
@@ -480,10 +480,6 @@
 }
 
 int CBS_peek_asn1_tag(const CBS *cbs, CBS_ASN1_TAG tag_value) {
-  if (CBS_len(cbs) < 1) {
-    return 0;
-  }
-
   CBS copy = *cbs;
   CBS_ASN1_TAG actual_tag;
   return parse_asn1_tag(&copy, &actual_tag) && tag_value == actual_tag;